Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


On 16/10/2018 16:03, Caolán McNamara wrote:
On Tue, 2018-10-16 at 12:33 +0000, scan-admin@coverity.com wrote:

** CID 1440303:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/core/data/column3.cxx: 2394 in
<unnamed>::FormulaToValueHandler::Entry::Entry(<unnamed>::FormulaToVa
lueHandler::Entry&&)()

FWIW I think the const-ing up of loplugin:constfields effectively
disables move constructors


https://www.chromium.org/rvalue-references?tmpl=%2Fsystem%2Fapp%2Ftemplates%2Fprint%2F&showPrintDialog=1#TOC-8.-Move-constructors-will-only-bind-to-non-const-rvalues
.

the poor consequences of loplugin:constfields notwithstanding, i think the coverity warning is bogus or incomplete: ScCellValue's both copy and move ctors are potentially throwing, so Entry's impl defined move ctor may indeed throw an exception, but will impl have a potentially throwing exception spec (whether or not Entry's

        ScCellValue const maValue;

member is const). and the coverity analysis doesnt show that such an exception isnt caught, but claims "If the exception is ever thrown, the program will crash."

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.