Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


On Wednesday 10 of October 2018, Stephan Bergmann wrote:
The underlying issue is that the internals of Clang's UBSan use the
Itanium ABI's notion of type equality (checking for RTTI pointer
equivalence), not GCC's weaker notion (checking for RTTI string
equivalence).  That requires some adjustments when building LO for
UBSan, to make sure RTTI for types used across library boundaries gets
exported from libraries.  I don't think we are doing anything inherently
"right" or "wrong" here.

 I get that, but what I'm saying is that if we do need to pass obscure 
seemingly unrelated options to the compiler to make UBSan work, then we are 
either working around problems that UBSan should be responsible for, or we 
are doing something wrong. And maybe what we do is realistically the best 
choice, but we should at least stop for a moment before adding a workaround 
for a workaround for a workaround.

If you plan to make choice of --enable-ld=... implicit in configure.ac,
then yes, please do so in a way that verifies that the implicitly chosen
linker supports --dynamic-list-cpp-typeinfo if that will be needed by
the build's solenv/gbuild/platform/unxgcc.mk.

 It's a corner case, but fair enough.

-- 
 Luboš Luňák
 l.lunak@collabora.com

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.