Re: Build error on Windows

On 10/10/2018 09:58, Gabor Kelemen wrote:
> [build DEP] LNK:Library/dbmmlo.dll
>     Creating library 
> D:/LibreOffice/core/workdir/LinkTarget/Library/isubsequenttest.lib and 
> object D:/LibreOffice/core/workdir/LinkTarget/Library/isubsequenttest.exp
> [build LNK] Library/dbmmlo.dll
> [build DEP] LNK:Library/sdbtlo.dll
> [build LNK] Library/sdbtlo.dll
> [build MOD] desktop
>     Creating library 
> D:/LibreOffice/core/workdir/LinkTarget/Library/ivclplug_win.lib and 
> object D:/LibreOffice/core/workdir/LinkTarget/Library/ivclplug_win.exp
> [build MOD] dtrans
>     Creating library 
> D:/LibreOffice/core/workdir/LinkTarget/Library/idbaxml.lib and object 
> D:/LibreOffice/core/workdir/LinkTarget/Library/idbaxml.exp
> [build CMP] embeddedobj/source/msole/emboleobj.windows
> salframe.o : error LNK2019: unresolved external symbol 
> __imp__SHStrDupW@8 referenced in function "long __cdecl 
> InitPropVariantFromString(wchar_t const *,struct tagPROPVARIANT *)" 
> (?InitPropVariantFromString@@YAJPB_WPAUtagPROPVARIANT@@@Z)
> D:/LibreOffice/core/instdir/program/vclplug_winlo.dll : fatal error 
> LNK1120: 1 unresolved externals
>     Creating library 

Looks like a bug in 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=1698debed2993fc5f262aa3ebbdb32fc112ac556> 
"Implement Windows VCL backend as plugin", which removed the shlwapi 
dependency from vcl/Library_vcl.mk but didn't add it to 
vcl/Library_vclplug_win.mk.