On the other hand, do we really consider what sd/source/ui/inc/unokywds.hxx
exhibits to be good style?
My personal impression has been that we want to eventually get rid of stuff
like this and just use literal strings as such in the code, and I have
occasionally committed changes like that.
But of course, I have to admit that exactly the kind of error that Regina
is fixing here would not have happened if that svdlayer.cxx file had
consistently only used variables containing those strings.
Still... I can't stand how unokywds.hxx completely arbitrarily sometimes
spells the variable exactly using the same case of characters as the
contents (for example sUNO_Service_FillProperties[] =
"com.sun.star.drawing.FillProperties"), sometimes differently (for
example sUNO_PseudoSheet_SubTitle[] = "subtitle" and sUNO_shape_zorder[] =
"ZOrder"). No consistency at all. Infuriating.
it is also annoying if some string is *both* present as literals here and
there, and *also* as the contents of some const variable in other places.
And maybe as another const variable in still other places. And a #define in
even more places....
--tml
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.