Re: broken radio/checkboxes in LibreOffice 6.1 (was: Re: UI regressions in "gen" plugin with LibreOffice 6.1)

Hi,

On Sun, Aug 12, 2018 at 04:58:52PM +0300, Maxim Monastirsky wrote:
> On Sun, 2018-08-12 at 14:43 +0200, Rene Engelhard wrote:
> > so vcl/source/app/IconThemeSelector.cxx
> >  
> > > installedThemes)
> > > {
> > >     if (!installedThemes.empty()) {
> > >         return installedThemes.front().GetThemeId();
> > >     }
> > >     else {
> > >         return FALLBACK_ICON_THEME_ID;
> > >     }
> > > }
> >
> >
> > $ git grep FALLBACK_ICON_THEME_ID
> > source/app/IconThemeSelector.cxx:/*static*/ const OUStringLiteral
> > IconThemeSelector::FALLBACK_ICON_THEME_ID("tango");
> >                                                                      
> >                                         ^^^^^
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> IconThemeSelector::ReturnFallback has a parameter const
> std::vector<IconThemeInfo>& installedThemes. The code which calls this
> method, passes there a reference to IconThemeScanner::mFoundIconThemes,
> which dynamically filled with the themes found in the installation
> folder. Now, it returns FALLBACK_ICON_THEME_ID (currently set to tango)
> only if installedThemes.empty(), meaning that we couldn't find any icon
> theme in the installation folder (including tango!). So normally, when
> there is at least one theme installed, this "return
> FALLBACK_ICON_THEME_ID" will never happen.

Ah, I see, didn't look that deep I have to admit. And because one other
theme is installed (tango) it took that one and it broke.

Thanks for the explanation.

(As said: libreoffice-common now Depends: libreoffice-style-colibre,
libreoffice-style-tango so it should now work in all "default" cases.
And -gnome/-kde Depends: libreoffice-style-elementary /
libreoffice-style-breeze for their iconsets)

Regards,

Rene