Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


Following good tradition of not discussing the usefulness of EasyHack bugs directly in bugzilla, lets do that here:

Shall we close the EasyHack <https://bugs.documentfoundation.org/show_bug.cgi?id=96099> "Reduce number of typedefs used for trivial container types" for good now?

While there are certainly the obviously silly, use-once cases like

  typedef std::vector<int> IntVector;
  IntVector v = ...;

there are also cases where such a typedef introduces domain-specific vocabulary into a (larger) portion of the code (e.g., see removal of such typedefs in <https://cgit.freedesktop.org/libreoffice/core/commit/?id=89e0663c55f7f1763536a345d63111115c71ef26> "tdf#96099 fix trival typedefs, Path to std::vector<OUString>" in configmgr and <https://cgit.freedesktop.org/libreoffice/core/commit/?id=5437eb15ad3975b11c6eefe77dfd6687e0e73f81> "tdf#96099 Remove trivial std::map typedefs in [cd]*" removing the Dependencies typedef from codemaker/source/javamaker/javatype.cxx). In such cases, there is always a tension between keeping the code simple (in the sense of easily understood by using well-chosen names) and keeping the code simple (by not introducing unnecessary abstractions), and finding the right balance there is likely not an easy hack.

(Tor's initial description, <https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c0>, already warned about that, but it's not clear to me that that warning has always been taken into account adequately.)

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.