Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


On 20/05/17 11:40, Michael Meeks wrote:
        Julien had some good ideas for simplifying VclPtr usage; here is the
background - currently we have:

        VclPtr<Foo> pFoo;
                + empty VclPtr pointer eg. shared_ptr<Foo> xFoo;

        VclPtrInstance<Foo> pFoo( pParent );
                + creates a pFoo as above, and initializes it to an
                  instance; we can't expose 'new Foo()' publicly due
                  to the odd reference counting behavior. ::Create
                  is a little like make_shared
                + sementically this is:
                  VclPtr<Foo> pFoo = VclPtr<Foo>::Create( pParent );

        * Suggestion - lets kill VclPtrInstance in a world with
          'auto' its main use of saving a bit of typing is gone
          ie.

                auto pFoo = VclPtr<Foo>::Create( pParent );

One more argument supporting that, <https://cgit.freedesktop.org/libreoffice/core/commit/?id=74b6e61dde64c5e24bffacda6f67dbf3d1fc7032> "-Werror,-Wreturn-std-move (recent Clang trunk)":

"An explicit std::move would be needed in the return statements, as there's a conversion from VclPtrInstance to base class VclPtr involved. One more reason to better get rid of VclPtrInstance completely in favor of VclPtr::Create, as already mentioned in [this mail thread]."

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.