minutes of ESC call ...

* Present:
    + Olivier, Caolan, Stephan, Miklos, Xisco, Eike, Sophie, Michael S
      Kendy, Michael M, Jan-Marek, Thorsten

* Completed Action Items:

* Pending Action Items:
    + come up with a plan for un-blocking peak CI in future (Christian)
       [ still pending ]
    + come up with a list of retiring committers to mail (Norbert)

* Release Engineering update (Xisco)
    + No builds this week.
    + Next up:
      + 6.0.3 – RC1 and branch next week (end of week March 15/Thu)
      + 5.4.6 - RC2 next week (beginning of week March 13/Tue)
      + Android
      + Online

* Documentation (Olivier)
     + Help pages contents: 208 Open bugs (+1)
          + 2 unconfirmed
     + 22 patches for Help contents by (G Kelemen, fitochido, A Gelmini)
     + New help: improvements in OS detection in <switch> (ohallot)
          + Pending: new help packaging (tdf#116240)
          + Meta bug: tdf#97629
     + Help online editor : resuming with Mike Saunders and Liongold.
     + Guides:
          + progress in revision for GS 6.0 (+ 3 chapters reviewed)
     + should the help directory contain the version # ? (Stephan)
          + would be better to remove redundant ver in install set.
          + will open a bug and fix it (Olivier)
  
* UX Update (Heiko)
    + Heiko on vacation next ~two weeks.
    + Bugzilla (topicUI) statistics
        248(248) (topicUI) bugs open, 326(326) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month    3 months   12 months  
             added      9(1)     21(1)      40(3)      118(6)  
         commented     42(13)   157(-22)   446(-13)   1988(-13)
           removed      0(0)      0(0)       0(-2)      13(-1) 
          resolved      3(2)      9(-2)     38(-2)     185(-3) 
    + top 10 contributors:
          Tietze, Heiko made 94 changes in 1 month, and 869 changes in 1 year
          Buovjaga made 44 changes in 1 month, and 234 changes in 1 year
          Thomas Lendo made 38 changes in 1 month, and 432 changes in 1 year
          Foote, V Stuart made 38 changes in 1 month, and 310 changes in 1 year
          Xisco Faulí made 16 changes in 1 month, and 290 changes in 1 year
          Telesto made 11 changes in 1 month, and 88 changes in 1 year
          Philips, Yousuf made 11 changes in 1 month, and 767 changes in 1 year
          Kainz, Andreas made 10 changes in 1 month, and 38 changes in 1 year
          Kevin Suo made 9 changes in 1 month, and 9 changes in 1 year
          Benes, Luke made 8 changes in 1 month, and 11 changes in 1 year

* Crash Hunting (Caolan)
    + 0 (+0) import failure, 1(+0) export failures
      + last week’s value.
    + ?? 4(+0) coverity
      + coverity scan is still down for synopsys rebranding (maybe)
      + down permanently ? Over a week being re-branded.  
    + forcepoint
      + fixed the last set of reports, lots of nullptr de-referencing
      + sent sample docs to AOO for reference.
    + 45 fuzzers * 3 sanitizers+engine combos (asan+libfuzzer,
            ubsan+libfuzzer, asan+afl), font parser last added
      + addressed a number of timeout issues
      + down to ~20 fuzzing issues there.
      + test case documents are sometimes used by other doc fuzzers
         + causing issues for other people

* Crash Reporter (Xisco)
    + http://crashreport.libreoffice.org/stats/version/5.3.7.2
        + 764 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/5.4.4.2
          + 665 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/5.4.5.1
          + 706 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/6.0.0.3
          + 2002 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/6.0.1.1
        + 1053 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/6.0.2.1
        + 714 (last 7 days) (-)

    + The crash report service was down for 2 days last weekend

    + Jmux & Michael worked on the virtual-pointer issue
        + discovered mpGraphics2 – was never freed on Windows
          since it was introduced in 2000 – the cause.
        + pushed patch to master & -6-0 – hopefully will improve.

* GSoC Application (Thorsten, Heiko)
   + 14 mentors so far (+8 pending)
   + would be good to check that people are responding to their mentor mails
       + if you want to mentor: add yourself to wiki page & check for invites.

 * GSoC schedule
   + Student Application Period: March 12 – 27
   + Application Review Period: March 27 - April 23
   + [libo] Deadline for EasyHack submission - March 31st  
   + [libo] Deadline for merge of EasyHack – April 7th 
   + Student Projects Announced: April 23
   + Community Bonding: April 23 - May 14
   + Coding: May 14 - August 6
   + Evaluation 1: June 11 - 15
   + Evaluation 2: July 9 - 13
   + Students Submit Code and Final Evaluations: August 6 - 14
   + Mentors Submit Final Evaluations: August 14 - 21
   + Results Announced: August 22

   + Created a 2018 wiki page with detailed dates (Eike)
     + https://wiki.documentfoundation.org/Development/GSoC/2018
     + please check the LibreOffice internal deadlines for EasyHacks
        + internal deadlines adjusted to match previous years.
        + cf. above insertions [libo]

   + Everybody look at the ideas page, please:
     + https://wiki.documentfoundation.org/Development/GSoC/Ideas

* Hackfests & Events (Eike)
     + Hamburg TNG – 1st new-style hackfest
        + outlined for April 7/8th.
                + https://wiki.documentfoundation.org/Hackfest/Hamburg2018 
            + https://wiki.documentfoundation.org/Hackfests/HackfestTNG
        + please book travel & add your name there.
        + hope to combine it with the German Community Meeting …
     + would be good to reach out to more people if we can.
     + Mike S to do a social media outreach on this (Sophie)

* Weld / widgetry (Caolan)
    + demos at LibOCon of native widgets & dialogs
    + fallback to native dialogs / widgets
    + all message-dialogs converted over to native last week.
    + obvious one warning: “have you saved document”
    + working on some sample dialogs to get a feel here.
    + async pieces
       + looking at this today.
       + been extending this; to keep dialogs working.
       + produce an async case for gtk+ too.
       + keep controller / builder around.
    + lifecycles should match.
    + creating a new API for all widgetry
       + examples so far – very basic.
    + sometimes need more calls
       + bit of work still; no point in doing it on a branch.
    + std::function – lambda instead of link ? (Michael)
       + looking at little differences causing problems already (Caolan)
    + long way to go yet
    + tree view is a tricky thing
    + assumptions in the glade files causing grief too.
    + min/max values for spin-buttons – real sharing etc.
    + a11y ? (Michael)
       + so far all one or other toolkit (Caolan)
          + fits into existing native gtk a11y work.
    + fixing mis-parented dialogs at the same time.

* Exotic Filter warnings (Michael)
     + https://gerrit.libreoffice.org/#/c/50387/
     + presents a warning on very unusual file formats
     + defaults vs. implementation
     + perhaps dialog trains people to click ok anyway ? (Michael S)
     + value tagging them (Miklos)
        + prefer a safe-mode, but its lots of work.
        + the dialog gives value for little effort.
        + MSO triggers something similar for network drives.
     + tie it into safe-locations (Stephan)
        + stuff you stored yourself – considered safe, vs. E-mail unsafe.
        + love it (Michael)
     + Microsoft has a similar warning for old binary file formats (Caolan)
        + may be useful text.
     => discuss defaults later & get it in now.

* mentoring/easyhack update
          committer...   1 week    1 month     3 months     12 months    
                  open      67(-2)    109(13)     112(15)       116(15)  
               reviews     608(15)   2224(187)   6234(478)    20868(1204)
                merged     319(13)   1340(-64)   4037(-110)   12908(148) 
             abandoned      13(-1)     64(-14)    274(-8)       830(2)   
           own commits     329(31)   1322(-40)   4076(-34)    14784(2)   
        review commits      89(-6)    322(8)      955(9)       3332(28)  
        contributor...   1 week     1 month      3 months     12 months    
                  open      20(-3)      34(-1)       38(0)         42(0)   
               reviews     812(-25)   2921(-356)   7971(-696)   25881(-857)
                merged      44(3)      157(2)       410(22)      1371(-1)  
             abandoned      10(6)       21(7)        63(0)        323(0)   
           own commits      41(7)      146(-4)      402(20)      1118(13)  
        review commits       0(0)        0(0)         0(0)          0(0)   
    + easyHack statistics:
       needsDevEval 35(35)   needsUXEval 2(2)   cleanup_comments 207(207)   
       total 253(253)   assigned 22(22)   open 192(192)   
    + top 5 contributors:
          Johnny_M made 48 patches in 1 month, and 101 patches in 1 year
          Gelmini, Andrea made 30 patches in 1 month, and 321 patches in 1 year
          Jim Raykowski made 13 patches in 1 month, and 41 patches in 1 year
          Samuel Thibault made 12 patches in 1 month, and 12 patches in 1 year
          Ilmari Lauhakangas made 7 patches in 1 month, and 36 patches in 1 year
    + top 5 reviewers:
          Stahl, Michael made 272 review comments in 1 month, and 2190 in 1 year
          Pootle bot made 271 review comments in 1 month, and 1177 in 1 year
          Timar, Andras made 160 review comments in 1 month, and 682 in 1 year
          Mohrhard, Markus made 157 review comments in 1 month, and 997 in 1 year
          Behrens, Thorsten made 121 review comments in 1 month, and 1340 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Franklin Weng franklin@goodhorse.idv.tw 
          Andika Triwidada andika@gmail.com 

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep for 6 weeks.

* Jenkins / CI update (Xisco)

    + master gerrit verification switched from "Matrix project" to
      "Multi Job" in Jenkins.
    + configured to kill all other jobs if one platform fails
    + status page only shows builds actually building, no confusion anymore with
      links going to previous buildresults in case there is no queueslot for a
      given config
    + now shows duration of the builds and direct link to the log
    + allows to "resume" builds (similar to retrigger, but only requeues
      configs that failed or were aborted, so useful if a build breaks with
      a spurious failure in a test on only one system when the others had
      already been built)

    + Dramatic decrease in verification times seen (Miklos, Eike)

    "cons": order of builds is no longer static, but depending on when the build
     gets actually started (but don't really a drawback from my POV, typically
     you're only interested in the status/color of a build and don't really care
     whether it failed on Windows or Mac, you'd open the log anyway to have a look.

from:Thu Mar  1 15:35:45 2018
master linux rel  jobs: 154 ok: 154 ko:   0 fail ratio:  0.00 % break:
  0 broken duration: 0.00%
master linux dbg  jobs:  78 ok:  76 ko:   1 fail ratio:  1.28 % break:
  1 broken duration: 2.74%
master mac rel    jobs:  81 ok:  81 ko:   0 fail ratio:  0.00 % break:
  0 broken duration: 0.00%
master mac dbg    jobs:  83 ok:  82 ko:   1 fail ratio:  1.20 % break:
  1 broken duration: 0.18%
master win rel    jobs:  41 ok:  29 ko:  12 fail ratio: 29.27 % break:
  7 broken duration:40.82%
master win dbg    jobs:  52 ok:  47 ko:   5 fail ratio:  9.62 % break:
  4 broken duration:12.11%
master win64 dbg  jobs:  49 ok:  42 ko:   7 fail ratio: 14.29 % break:
  4 broken duration:11.78%
lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:
  0 broken duration: 0.00%
lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:
  0 broken duration: 0.00%
master gerrit lin jobs: 448 ok: 312 ko:  18 fail ratio:  4.02% time
for ok: mean:  10 median:   9
master gerrit plg jobs: 449 ok: 293 ko:  47 fail ratio: 10.47% time
for ok: mean:  21 median:  18
master gerrit win jobs: 453 ok: 273 ko:  74 fail ratio: 16.34% time
for ok: mean:  51 median:  50
master gerrit mac jobs: 449 ok: 290 ko:  20 fail ratio:  4.45% time
for ok: mean:  47 median:  29
master gerrit all jobs: 452 ok: 269 ko: 157 fail ratio: 34.73% time
for ok: mean: 103 median:  96

Notes on stats:
single failure fails/aborts the whole project, so failure rates for individual
OS to be taken with a grain of salt/depending on which have available executors
(who has a chance to build first, has a chance to fail first, and thus the rest
isn't running into the issue/won't appear in stats as failed)

Windows had problems with buildslave issues that failed lots of builds, so both
windows (as well as overall failure rate) not as bad as the plain numbers
suggest.

New columns in stats: average/mean and median buildtimes for successful builds.

* Budgeting (Thorsten)
    + collecting other wish-lists – cross-check with GSoC ideas
    + current ideas list:
        https://wiki.documentfoundation.org/Development/Budget2018
    + deadline of the hack-fest for submitting ideas.
    + Thorsten watching edits to discuss controversial bits here.

* l10n (Sophie)
    + po template has been updated; new l10n round for master.
    + translation is ongoing, a l10n camp happening in Nepal right now.

* ODF & incompatible changes (Michael S)
    + open question – releases before dropping workarounds (Miklos)
       + N=5 → 2.5 years seems reasonable.
    + triggered by a bug related to such a change
       + fix in 5.3 back-ported; export change in 6.0 branch
         bit too short of a time-frame for such a change.
       + reverted export change in 6.0 branch.
    + should we comment with times to remove – 2020-06 ? (Michael)
       + since we can’t map times to versions easily.
       + fortunately not happened in the last couple of years
          + some from the OO times.
          + odd bug, whereby ‘hidden’ attribute on paragraphs stored
            with an inverted value – all paras were hidden.
            Fixed in 2.0 by checking generator: 
    + generator string is tricky (Eike)
       + branded name + version information
       + need some static identifier
       + do write major/minor version (Michael S)
           + could be a branded product.
           + might be a problem.
       + ideally should have programatic non-branded name + branded
       + in C’bra branch – write Collabora + LibreOffice_project (Miklos)
           + info is there in the documents: the hard bit to change.

* QA update (Xisco)

    + as of today – down to 440 unconfirmed.

    + UNCONFIRMED: 485 (-8)
        + enhancements: 57  (-6)
        + needsUXEval: 8 (+5)
        + haveBackTrace: 5 (+0)
        + needsDevAdvice: 25 (+1)
        + documentation:  2 (-1)
        + android:  17 (-1)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
                [None]
        
        + Older:
             + Crash when asking subtotals on 2 groups with pre-sort area checked
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=116003
                   + cf. https://bugs.documentfoundation.org/show_bug.cgi?id=114720
                   + Ahmed looking into it

             + EDITING: CRASH when paste special source.ods as GDI metafile
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114710
                   + kohei ?
                   + potentially remove this ?
          
        + Fixed:
             + Crash using "Close" button for Extension Manager -> Check/Updates
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=115420
                   + lots of duplicates here – 200 crash reports this week.
                   + fixed thanks to JMux & Michael M

             + Crash in dialog Edit page break
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=116070
                   + fixed thanks to Kendy.

             + EDITING: Crash while selecting cell format with double-click
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=115950
                   + fixed thanks to Kendy.

             + Creating Documents with Wizard Crashes LibreOffice
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=116147
                   + fixed thanks to jmux

             + Delete relationship in base. Crash in: 
google_breakpad::ExceptionHandler::HandlePureVirtualCall()
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=115998
                   + fixed thanks to Noel Grandin


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +182  +17 (-140) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             25
       Buovjaga                10
       Aron Budea              8
       Mike Kaganski           7
       Timur                   7
       Heiko Tietze            6
       Olivier Hallot          6
       Julien Nabet            5
       V Stuart Foote          5
       Telesto                 4

    + top 10 bugs reporters:
       Telesto                 7
       Mike Kaganski           6
       am_dxer                 5
       Heiko Tietze            4
       skierpage               3
       twisterddfsl83823       3
       Frederic Parrenin       3
       Aron Budea              3
       Samuel Mehrbrodt (CIB)  2
       Volga                   2

    + top 10 bugs fixers:
       Kaganski, Mike          6
       Olivier Hallot          6
       Le Grand, Armin         3
       Xisco Faulí             3
       Vajna, Miklos           3
       Florian Reisinger       2
       Budea, Áron             2
       Philips, Yousuf         2
       Mohrhard, Markus        2
       Lillqvist, Tor          2

    + top 10 bugs confirmers:
       Xisco Faulí             24
       Buovjaga                19
       Timur                   13
       Alex Thurgood           11
       Nabet, Julien           9
       Tietze, Heiko           8
       Dieter Praas            8
       Budea, Áron             7
       *UNKNOWN*               4
       Raal                    4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 3/53 -     5 %  (+0)
     5.2 : 1/40 -     2 %  (-3)
     5.1 : 1/35 -     2 %  (+0)
     5.0 : 2/63 -     3 %  (+0)
     4.4 : 2/76 -     2 %  (+0)
     4.3 : 6/75 -     8 %  (+0)
     4.2 : 7/135 -    5 %  (+1)
     4.1 : 3/84 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 23/259 -   8 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 449/1940 442/1921 436/1899 438/1888 434/1876 429/1856 428/1848 

     done by:
        Xisco Faulí           11
        Budea, Áron            4
        Benes, Luke            1
        Telesto                1
        Raal                   1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 543/2563 534/2539 531/2520 534/2508 529/2495 523/2475 523/2468 

     done by:
        Xisco Faulí               15
        Budea, Áron                3
        Balland-Poirier, Laurent   1
        Foote, V Stuart            1
        am_dxer                    1
        Terrence Enger             1
        Raal                       1


* all bugs tagged with 'regression'
   + 917(+10) bugs open of 6823(+31) total 11(-1) high prio.

     done by:
        Xisco Faulí           13
        Timur                  3
        Alex Thurgood          3
        Budea, Áron            3
        Nabet, Julien          2
        Foote, V Stuart        1
        Terrence Enger         1
        Raal                   1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Impress       - 4(+1)
     Writer        - 3(+1)
     LibreOffice   - 2(-2)
     Calc          - 2(+0)
     graphics stack - 0(-1)

   by OS:
     All           - 6(+0)
     Windows       - 2(+2)
     Linux         - 1(+0)
     Mac OS X      - 2(-3)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 176(+7)
     Calc                     - 154(+0)
     Impress                  - 108(+3)
     Writer: docx filter      - 72(+0)
     LibreOffice              - 67(-3)
     UI                       - 47(+1)
     graphics stack           - 35(+0)
     Draw                     - 34(+0)
     Writer: doc filter       - 33(+0)
     Base                     - 31(+1)
     Borders                  - 30(+0)
     Writer: perf             - 29(+0)
     filters and storage      - 28(+1)
     Writer: other filter     - 26(+0)
     Crashes                  - 25(+4)
     Chart                    - 21(+1)
     Printing and PDF export  - 19(+1)
     BASIC                    - 17(+0)
     framework                - 4(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)
     Linguistic               - 1(+0)
     Extensions               - 1(+0)