Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


Hi Armin, hi all,

this is about https://bugs.documentfoundation.org/show_bug.cgi?id=115590 and my proposal https://gerrit.libreoffice.org/#/c/50176/

It works in principle, but I'm not sure about some details:

A
It has a construction
    basegfx::B2DHomMatrix aFullTransform;

    with later on
    if ( !aFullTransform.isIdentity() )

Should I use
    basegfx::B2DHomMatrix aFullTransform;
    bool bHasTransformation;

    if ( bHasTransformation )
instead?

B
It has
    if ( aTransformedCenterPosition != aCenterPosition )
Is this check useful, or should I calculate the correction always, although the result might be the original value?

C
Is this the correct place at all to correct the position?

Kind regards
Regina

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.