Hello,
I initially filed
https://bugs.documentfoundation.org/show_bug.cgi?id=115931 but it was
suggested to me to raise the issue on the mailing list instead.
So here it goes: when building libreoffice 6.0 with an external
liborcus (version 0.13.3), unit tests fail:
subsequent_filters-test.cxx:2398:Assertion
Test name: ScFiltersTest::testOrcusODSStyleInterface
equality assertion failed
- Expected: Color: R:254 G:255 B: 204
- Actual : Color: R:255 G:255 B: 255
This is most likely caused by that upstream change:
https://gitlab.com/orcus/orcus/commit/f821995022df8dd1e580dd22cf131584b2b1ac4f
I'm not familiar with that code, but I came up with a tentative patch
(which I will actually put to the test soon):
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -839,7 +839,7 @@ void ScOrcusStyles::fill::applyToItemSet
return;
}
- rSet.Put(SvxBrushItem(maBgColor, ATTR_BACKGROUND));
+ rSet.Put(SvxBrushItem(maFgColor, ATTR_BACKGROUND));
}
Thoughts and feedback welcome!
Regards,
Olivier
Context
- ScFiltersTest::testOrcusODSStyleInterface fails with liborcus 0.13.3 · Olivier Tilloy
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.