Re: New Defects reported by Coverity Scan for LibreOffice

Hi,

It wasn't intentional. My fix is already on gerrit: 
https://gerrit.libreoffice.org/#/c/49592/

Regards,

Szymon


W dniu 10.02.2018 o 18:13, Caolán McNamara pisze:
> On Fri, 2018-02-09 at 18:50 +0000, scan-admin@coverity.com wrote:
> > Hi,
> >
> > Please find the latest report on new defect(s) introduced to
> > LibreOffice found with Coverity Scan.
> >
> > _____________________________________________________________________
> > ___________________________________
> > *** CID 1429181:    (DEADCODE)
> > /sd/source/filter/eppt/pptx-epptooxml.cxx: 816 in
> > oox::core::PowerPointExport::WriteTransition(const
> > std::shared_ptr<sax_fastparser::FastSerializerHelper> &)()
> since...
>
> commit fa85592c0efba65f4a1b09fea950ec1c311bdd4c
> Author: Szymon Kłos <szymon.klos@collabora.com>
> Date:   Mon Feb 5 12:41:58 2018 +0100
>
>      tdf#115394 export custom transition time in PPTX
>
> bool isAdvanceTimingSet = advanceTiming != -1;
>
> was added, but its above the line which might change advanceTiming away
> from its default of -1 (i.e. mAny >>= advanceTiming) is that
> intentional or is there something to be fixed ?