Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


Recent master --enable-pdfium has at workdir/UnpackedTarball/pdfium/third_party/base/allocator/partition_allocator/page_allocator.h:31

// All Blink-supported systems have 4096 sized system pages and can handle
// permissions and commit / decommit at this granularity.
static const size_t kSystemPageSize = 4096;

and upstream master at <https://pdfium.googlesource.com/pdfium/+/026717cb667cf0c7215cf55daf794d69752fc900/third_party/base/allocator/partition_allocator/page_allocator.h#33> isn't much better with

// All Blink-supported systems have 4096 sized system pages and can handle
// permissions and commit / decommit at this granularity.
// Loongson have 16384 sized system pages.
#if defined(_MIPS_ARCH_LOONGSON)
static const size_t kSystemPageSize = 16384;
#else
static const size_t kSystemPageSize = 4096;
#endif

This causes failure e.g. on Linux aarch64 machines with 64K page size, see <https://cgit.freedesktop.org/libreoffice/core/commit/?id=ffc134445ef7e935d18d816626f64e65b4cdbca6> "--disable-pdfium for Linux aarch64 Flatpak build", but other platforms may be affected, too. (On RH internal tech-list I got comments "NB, even before aarch64 came along, that code is broken because ppc64 uses a 64kb page size by default." and "And alpha and sparc/sparc64 use 8K pages, for example. Not to mention that a lot of other architectures have configurable page size.")

So think twice before you live with (enabled-by-default) --enable-pdfium.

Or start searching for an alternative?

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.