Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


Hey Michael,

see the referenced commit. I disabled the test for now as it seems that
there are a number of problems. Maybe you can have a look at them.

Regards,
Markus

---------- Forwarded message ----------
From: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date: Sun, Jan 7, 2018 at 10:17 PM
Subject: [Libreoffice-commits] core.git: toolkit/Module_toolkit.mk
To: libreoffice-commits@lists.freedesktop.org


 toolkit/Module_toolkit.mk |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 43dd63898c145ebeb918f1d6ce094cf5c68548c8
Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date:   Sun Jan 7 22:15:13 2018 +0100

    disable toolkit unit conversion test for now

    There seems to be a bunch of problems:

    On OSX the test crashes when no display can be found:
    https://ci.libreoffice.org/job/lo_gerrit/25298/Config=
macosx_clang_dbgutil/console

    On windows the position seems to be wrong on some boxes, e.g.:
    D:/lode/dev/core/toolkit/qa/cppunit/UnitConversion.cxx(149) : error :
Assertion
    Test name: `anonymous namespace'::ToolkitTest::testXUnitConversion
    equality assertion failed
    - Expected: 100
    - Actual  : 72
    - Window pos wrong

    Change-Id: Id100817cf9024986f790c2bfbf2ddaefcd2dd080

diff --git a/toolkit/Module_toolkit.mk b/toolkit/Module_toolkit.mk
index b5e4bdee01b4..74a9d5d78ffc 100644
--- a/toolkit/Module_toolkit.mk
+++ b/toolkit/Module_toolkit.mk
@@ -23,9 +23,9 @@ $(eval $(call gb_Module_add_targets,toolkit,\
     Library_tk \
 ))

-$(eval $(call gb_Module_add_check_targets,toolkit,\
-    CppunitTest_toolkit \
-))
+#$(eval $(call gb_Module_add_check_targets,toolkit,\
+#    CppunitTest_toolkit \
+#))

 ifneq ($(OOO_JUNIT_JAR),)
 $(eval $(call gb_Module_add_subsequentcheck_targets,toolkit,\
_______________________________________________
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.