minutes of ESC call ...

* Present:
    + Sophie, Michael M, Stephan, Kendy, Heiko, Xisco, Caolan, Miklos,
      Eike, Shinnok, Thorsten

* Completed Action Items:

* Pending Action Items:
    + come up with a list of retiring committers to mail (Norbert)
    + find code pointer auto-format table style config merging (Caolan)
    + mail the list wrt. bundling GPG-4-Win (Thorsten)
    + find data for x86 / Linux downloads with view to removing for 6.0 (Cloph)
        [ have the data, not broken down yet: termbin.com/2jc2 ]
    + fwd build details on Mac / CVE build / test failure to the list (Shinnok)
        [ Bartoz removed obsolete, non LODE details from the wiki
          removed quick-setup and mac-ports setup, recommends to
          --disable-cve-tests on the Mac. 
          It works for me; what’s the issue (Stephan)
          re-send the mail to the list / Stephan (Shinnok) ]

* Release Engineering update (Xisco)
    + 6.0 Beta 1 & feature freeze: week 47 (of Nov 20th)
        + late features
           + HTML help pieces (Kendy)
               [ still working to integrate some scripts into Makefiles (Olivier)
                  concern wrt. this getting finished (Kendy)
                     anyone interested could help Olivier with gnumake ]
           + GPG / Windows bits (Thorsten)
               [ still not in yet ]
           + bundling GPG-4-Win ? (Thorsten)
               [ removing this item – will link on website somewhere ]
           + Calc threading review with Eike (Michael)
               [ had a call, minutes on the list, doing last fixing before merge
                 SvNumberFormatter locking needs fixing first
                  + plan to have it enabled for beta (Eike)
                     + disabled / experimental for release (Eike) ].
           + KDE5 – merge but perhaps not ready for 6.0 (Thorsten)
               [ ignore this as a late-feature ]
           + Calc column span update from Noel (Michael)
               [ looking for help to get this integrated ]
           + missing piece from customization GSoC (Heiko)
               + mkara will try to submit a new patch by Monday
   + 5.4.4 RC1: week 48 (of Nov 27th) 
   + Android
   + Online

* Documentation (Olivier)
   + More work on integration of new help into build
       + Patch need advise for further improvements and developments
         https://gerrit.libreoffice.org/#/c/44793/ 
       + (gbuild makefiles not easy to hack !)
   + Getting Started guide 6.0
       + cover being voted until next Sunday (19)
       + awaiting latest 6.0 features to write about

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        258(258) (topicUI) bugs open, 375(375) (needsUXEval)
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months  
             added      4(-3)     20(0)     47(-1)     118(0)  
         commented     39(-33)   272(4)    631(-43)   2419(-26)
           removed      0(0)       0(0)      5(0)       20(-1) 
          resolved      2(-5)     21(-4)    52(-3)     241(1)  
    + top 10 contributors:
          Philips, Yousuf made 145 changes in 1 month, and 823 changes in 1 year
          Tietze, Heiko made 117 changes in 1 month, and 1153 changes in 1 year
          Faulí Tarazona, Xisco made 56 changes in 1 month, and 383 changes in 1 y
          Thomas Lendo made 45 changes in 1 month, and 428 changes in 1 year
          Zolnai, Tamás made 37 changes in 1 month, and 108 changes in 1 year
          Cor Nouws made 29 changes in 1 month, and 188 changes in 1 year
          Dieter Praas made 28 changes in 1 month, and 78 changes in 1 year
          Christian Lehmann made 18 changes in 1 month, and 18 changes in 1 year
          Foote, V Stuart made 17 changes in 1 month, and 400 changes in 1 year
          Henschel, Regina made 14 changes in 1 month, and 119 changes in 1 year
    + lots of discussion in UX call yesterday
    + Frames set to wrap-trough will be transparent by default tdf#71920
        + UX tweak to the defaults for frames (but not shapes, images)

    + Concerns to use the newly bundled Liberation font in templates
        + instead of Arial/Times? Or rather go with
           Calibri/Cambria/Carlito/Caladea | Noto.
           + https://gerrit.libreoffice.org/#/c/43625/
        + not blocking it (Kendy)
           + previously the shell extension used Arial
           + concern wrt. metric compatibility
        + don’t create documents as if they’re from a different program (Heiko)
           + Liberation good for branding.
        => go with new templates as is.

* clang-format-ness review (Miklos)
    + discussed versions situation with sberg
       => will give-up on supporting mutiple versions
       + git hook only works with 5.0.0 stable version
    + prints a warning if you modify a non-black-list file.
       + prints out a link to the binaries
    + would be nice to progress on gerrit integration
       + is it useful to have a script in core to validate the latest commit ?
       + ci would call the script – and heavy lifting is done.
    + can we catch a jenkins env. var ? (Kendy)
       + have an additional state in gerrit –
         verified → code review → code style +1/-1
           + nice and clean but …
       + can create a bot with permission to set +1 (Thorsten)
           + gerrit side is all prepared.
           + need S/W somewhere that pings & replies.
AI:    + script a ‘make check’ option (Miklos)
           + can all be in ‘core’ - a random ‘make’ target.
           + just check the last commit.
    + any problems this week ?

* Crash Hunting (Caolan)
    + 0 import failures, 3 export failures
        + lots of export fixes, new run underway
        + seems to have some stability now in import/export failures
        + perhaps fuzzing helping reduce randomness here too.
    + 125 coverity
        + caused by the new version of coverity
        + plan to iterate a couple of small patches to reduce them.
    + 38(+1) fuzzers * 3 sanitizers+engine combos (asan+libfuzzer, ubsan+libfuzzer,
        asan+afl)
        + enabled afl fuzzing engine as well.
        + get three entities from the 4 possible combinations
        + added DIF interchange format from calc
        + remaining modern MS office formats are ~done
        + decent trickle of things coming done.
        + AOO CC’d on all of these via officesecurity

* Crash Reporter (Xisco)
    + http://crashreport.libreoffice.org/stats/
        + server went down – poked Guilhelm, Markus etc.
            + back now – but less reports this week.

    + http://crashreport.libreoffice.org/stats/version/5.3.6.1
        + 1347 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.3.7.2
        + 347 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.2.2
          + 1720 (last 7 days )
    + http://crashreport.libreoffice.org/stats/version/5.4.3.2
          + 547 (last 7 days )

    + ScEditEngineDefaulter::SetDefaultItem(SfxPoolItem const &)
          + Most reported crash in 5.4.2 and 5.4.3
        + Reported since 5.4.2
          + Fixed in 5.4.4, thanks to Eike
          + https://bugs.documentfoundation.org/show_bug.cgi?id=113850

    + SfxSlotPool::GetSlotPool(SfxViewFrame *)
          + https://bugs.documentfoundation.org/show_bug.cgi?id=113755
          + Reported since 5.4
          + no reproducible steps so far
        + might be related to LibreOffice closing / shutdown with clipboard

* Hackfests & Events (Thorsten)
    + new plan from Bjoern:
       + https://skyfromme.wordpress.com/2017/08/27/hackfests-the-next-generation/
         + good suggestions from Regina
    + Hamburg – 1st new-style hackfest
         + deferred to next year ...
             + https://wiki.documentfoundation.org/Hackfests/HackfestTNG
         + timeframe is too narrow to risk it.
    + fallback plan for March in either Italy or Germany
    + still looking for people who want help learning how to fix
      their problems interactively at a hackfest.

* mentoring/easyhack update (Shinnok)
          committer...   1 week     1 month     3 months    12 months   
                  open      62(15)     120(14)     120(13)      126(13) 
               reviews     433(-69)   1862(196)   5015(-82)   18107(154)
                merged     248(-41)   1095(131)   2880(24)    11200(41) 
             abandoned      16(-1)      80(9)      197(1)       656(7)  
           own commits     306(-30)   1550(148)   3868(109)   13755(-94)
        review commits      50(-30)    282(13)     826(-14)    2738(-10)
        contributor...   1 week     1 month     3 months    12 months   
                  open      13(-1)      37(0)       39(1)        44(1)  
               reviews     722(-52)   2918(276)   7080(76)    23066(240)
                merged      16(-1)      75(3)      278(-16)    1213(7)  
             abandoned       4(2)       14(-1)      81(3)       339(3)  
           own commits      13(-6)      77(-2)     286(-23)     812(0)  
        review commits       0(0)        0(0)        0(0)         0(0)  
    + easyHack statistics:
       needsDevEval 31(31)   needsUXEval 0(0)   cleanup_comments 202(202)   
       total 257(257)   assigned 13(13)   open 210(210)   
    + top 5 contributors:
          Gelmini, Andrea made 24 patches in 1 month, and 178 patches in 1 year
          Johnny_M made 10 patches in 1 month, and 50 patches in 1 year
          Jim Raykowski made 6 patches in 1 month, and 11 patches in 1 year
          Udaree Kanewala made 4 patches in 1 month, and 6 patches in 1 year
          Pinto, Marco A.G. made 3 patches in 1 month, and 11 patches in 1 year
    + top 5 reviewers:
          Pootle bot made 270 review comments in 1 month, and 630 in 1 year
          Behrens, Thorsten made 190 review comments in 1 month, and 910 in 1 year
          Grandin, Noel made 177 review comments in 1 month, and 1393 in 1 year
          Stahl, Michael made 148 review comments in 1 month, and 1906 in 1 year
          Rathke, Eike made 104 review comments in 1 month, and 1076 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
    + met some eager new developers in Bucharest
        + getting them involved.
    + Csongor Halmai – in UX call yesterday
        + interested in some mentoring help if you can ?

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    [ have two names – no objections
AI:    mail out asking if they’d like to be certified (Stephan) ]

* Jenkins / CI update (Christian)
    + missing the stats.

* l10n (Sophie)
    + lots of fuzzy strings still ? (Michael)
       + waiting for Cloph to return.

* Hunspell (Thorsten)
    + unilateral change in license to LGPLv3 up-stream
    + annoying to drag 3x licenses around in headers (Michael)
       + best to use just one – MPLv2 –
         better for Mozilla, LibreOffice, Chromium 
    + it’s Laszlo’s project (Caolan)
       + unclear why the change was made
       + pointed out it was an issue – wrt. FF. bundling.
       + way things are/were wrt. licensing works: why change ?
          + pwrt. getting Laslo’s input
       + chromium using it too apparently.
    + complete re-writing plan looks interesting (Michael)
       + in its own world – fine, but …
          + mangling the original project’s license not helpful (Caolan)
    => poke them on the topic (Thorsten)

* QA update (Xisco)

    + very low unconfirmed count
        + lowest since joined TDF – now around ~350
        + buovjaga doing a great job here.
        + Xisco triaging them too
            + hoping to keep it under 400.

    + UNCONFIRMED: 370 (-52)
        + enhancements: 40  (-9)
        + needsUXEval: 1 (+0)
        + haveBackTrace: 6 (-1)
        + needsDevAdvice: 34 (+0)
        + documentation:  5 (+3)
        + android:  16 (-1)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
             + Impress can't play MP4 videos on Mac
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113622
                   + regression around media embedding
                   + still pending Xisco’s bisection on Mac.
                   + missing bibisect repos for 5.4 and 6.0
AI:                    + poke Norbert on this (Michael)
                   + bug arrived between between 5.3.4 RC2 & 5.3.5 RC1
                         + https://wiki.documentfoundation.org/Releases/5.3.5/RC1

        + Older:
                [None]

        + Fixed:
             + Crash when switching between Calc and other LO window
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113591
                   + fixed thanks to Samuel.

             + Crash click twice times on "New Theme..." in detached Gallery
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113647
                   + fixed thanks to Caolan.

             + Crash when trying to edit style with context menu of Date Area
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113826
                   + fixed thanks to Caolan.

             + Dragging a slide master from one window to another causes crash (steps in comment 2) 
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113405
                   + fixed thanks to Caolan.

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +130  +11 (-146) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             25
       Buovjaga                16
       Heiko Tietze            7
       Caolán McNamara         6
       Alex Thurgood           6
       Tamás Zolnai            5
       eisa01                  5
       Eike Rathke             5
       Julien Nabet            4
       Timur                   3

    + top 10 bugs reporters:
       Thomas Lendo            5
       Yousuf Philips (jay)    5
       Gabor Kelemen           4
       Kevin Suo               3
       Bartosz                 3
       Timon                   3
       Tamás Zolnai            3
       Samuel Mehrbrodt (CIB)  2
       Timur I. Davletshin     2
       Ole Tange               2

    + top 10 bugs fixers:
       McNamara, Caolán        6
       Zolnai, Tamás           4
       Glogowski, Jan-Marek    3
       Adolfo Jayme Barrientos 2
       Faulí Tarazona, Xisco   2
       Vajna, Miklos           2
       Nabet, Julien           2
       Mehrbrodt, Samuel       2
       Behrens, Thorsten       2
       Kara, Muhammet          1

    + top 10 bugs confirmers:
       Buovjaga                51
       Faulí Tarazona, Xisco   11
       Kevin, Suo (锁琨珑)        9
       Dieter Praas            8
       Foote, V Stuart         7
       Philips, Yousuf         5
       Tietze, Heiko           5
       Jacques Guilleron       4
       Alex Thurgood           4
       Kosiorek, Bartosz       3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 1/47 -     2 %  (-2)
     5.2 : 2/39 -     5 %  (+0)
     5.1 : 1/35 -     2 %  (+0)
     5.0 : 2/62 -     3 %  (+0)
     4.4 : 2/76 -     2 %  (+0)
     4.3 : 5/74 -     6 %  (+0)
     4.2 : 6/134 -    4 %  (+0)
     4.1 : 3/84 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 25/258 -   9 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 412/1749 422/1738 417/1716 410/1698 410/1669 400/1654 385/1631 

     done by:
        Budea, Áron             3
        Raal                    2
        Faulí Tarazona, Xisco   2
        Kevin, Suo (锁琨珑)        1
        Telesto                 1
        Kaganski, Mike          1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 499/2357 508/2344 502/2320 494/2299 490/2265 476/2247 462/2225 

     done by:
        Budea, Áron             4
        Kevin, Suo (锁琨珑)        2
        Raal                    2
        Faulí Tarazona, Xisco   2
        Telesto                 1
        Kaganski, Mike          1


* all bugs tagged with 'regression'
   + 877(-11) bugs open of 6539(+12) total 7(-1) high prio.

     done by:
        Kevin, Suo (锁琨珑)        3
        Faulí Tarazona, Xisco   2
        Buovjaga                1
        MM                      1
        Jim Avera               1
        Kaganski, Mike          1
        Raal                    1
        eisa01                  1
        Harald Koester          1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Impress       - 2(+0)
     Calc          - 1(+1)
     filters and storage - 1(+1)
     LibreOffice   - 1(+0)
     graphics stack - 1(+0)
     Writer        - 1(-3)

   by OS:
     All           - 4(-1)
     Mac OS X      - 3(+0)
     Windows       - 0(+0)
     Linux         - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 161(-2)
     Calc                     - 138(+0)
     Impress                  - 91(-1)
     Writer: docx filter      - 72(-1)
     LibreOffice              - 69(-2)
     UI                       - 49(+0)
     graphics stack           - 36(+0)
     Draw                     - 35(+1)
     Writer: doc filter       - 35(-1)
     Base                     - 30(+0)
     Writer: perf             - 29(+0)
     Borders                  - 28(-1)
     Writer: other filter     - 27(-2)
     filters and storage      - 26(+1)
     Crashes                  - 20(-1)
     Chart                    - 19(+0)
     Printing and PDF export  - 17(-1)
     BASIC                    - 15(-1)
     framework                - 5(+0)
     Linguistic               - 2(+0)
     sdk                      - 1(+0)
     Installation             - 1(+0)
     Extensions               - 1(+0)