minutes of ESC call ...

* Present:
    + Jan-Marek, Lionel, Caolan, Heiko, Miklos, Olivier, Xisco, Michael M,
      Sophie, Eike, Stephan, Kendy, Michael S

* Completed Action Items:
    + build new binary table style file for 32bits (Heiko)
        [ Michael S patched things so it works now, all working again,
          Nightly builds have the new styles now. ]
    + provide / check web-page on dev certification process (Kendy)
        [ poked Italo to find out what to check – unclear (Kendy)
          no idea what this was either (Sophie)
          → drop the task. ]
    + run dev certification script (Kendy/Thorsten)
        [ have one name without running the script ]

* Pending Action Items:
    + mail the list wrt. bundling GPG-4-Win (Thorsten)
    + find data for x86 / Linux downloads with view to removing for 6.0 (Cloph)
        [ have the data, not broken down yet: termbin.com/2jc2 ]
    + fwd build details on Mac / CVE build / test failure to the list (Shinnok)
        [ Bartoz removed obsolete, non LODE details from the wiki
          removed quick-setup and mac-ports setup, recommends to
          --disable-cve-tests on the Mac. 
          It works for me; what’s the issue (Stephan)
          re-send the mail to the list / Stephan (Shinnok) ]

* Release Engineering update (Xisco)
    + 5.4.3 RC2 released today
    + 5.3.7 RC2 released as final last week
    + 6.0 Alpha1 status
    + 6.0 Beta 1 & feature freeze: week 47 (of Nov 20th)
        + late featuresken
           + HTML help pieces (Kendy)
              [ still working to integrate some scripts into Makefiles (Olivier)
                  expect to have it working soon tomorrow / monday ]
           + GPG / Windows bits (Thorsten)
           + Calc threading review with Eike (Michael)
              [ will have a public call next week for those interested ]
           + KDE5 – merge but perhaps not ready for 6.0 (Thorsten)
               + can’t build on baseline anyway (Michael S)
           + bundling GPG-4-Win ? (Thorsten)
           + Calc column span update from Noel (Michael)
           + missing piece from customization GSOC (Heiko)
               + in past – could assign a macro command to a menu / toolbar item
                   + currently master has a significant regression ?
                   + really important (Xisco, Lionel, Michael)
                   + if you see office suite as a RAD base (Lionel)
                       + essential for custom business apps 
               + mkara has a patch to fix this:
                   + https://gerrit.libreoffice.org/#/c/42594/
                   + queries on impl. from Bubli.
               + if not ready for 6.0 – we revert it;
                 give some grace post feature-freeze perhaps.
               + could it be experimental perhaps & have the old ver ? (Kendy)
        + Updating service – expected to miss 6.0 (Cloph)
    + Android
    + Online

* Documentation (Olivier)
        + New fixes in help pages by G. Kelemen, M. Kaganski
        + Still working on new help packaging Makefiles (Olivier)
        + Started to work on an online XHP editor (Mike)
          + Contacted Jean Spiteri (liongold) and Ilmari (buovjaga) for assistance                  
    and collecting ideas (Mike)
        + Documentation team now looking for latest features to add contents to guide
                + Please add new features to wiki page.
        + Vote for next book cover blog post (Heiko)
          + Please vote! 
https://design.blog.documentfoundation.org/2017/11/08/cover-for-libreoffice/ 
          + can Olivier monitor and answer comments

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        261(261) (topicUI) bugs open, 383(383) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months  
             added      7(5)     20(0)     48(5)      118(3)  
         commented     72(27)   268(38)   674(109)   2445(77) 
           removed      0(0)      0(0)      5(-1)      21(0)  
          resolved      7(1)     25(2)     55(0)      240(2)  
    + top 10 contributors:
          Philips, Yousuf made 152 changes in 1 month, and 823 changes in 1 year
          Tietze, Heiko made 116 changes in 1 month, and 1163 changes in 1 year
          Thomas Lendo made 48 changes in 1 month, and 426 changes in 1 year
          Faulí Tarazona, Xisco made 48 changes in 1 month, and 384 changes in 1 y
          Cor Nouws made 46 changes in 1 month, and 207 changes in 1 year
          Zolnai, Tamás made 34 changes in 1 month, and 105 changes in 1 year
          Dieter Praas made 23 changes in 1 month, and 79 changes in 1 year
          Foote, V Stuart made 22 changes in 1 month, and 407 changes in 1 year
          Christian Lehmann made 14 changes in 1 month, and 14 changes in 1 year
          Henschel, Regina made 14 changes in 1 month, and 121 changes in 1 year

    + new default table style
    + new meeting time (evening either today or yesterday)
    + How to deal with user configuration? /user/4 => /user/6
          + changing a lot; old config. interferes with changes we made
          + how to upgrade user configuration ?
          + people don’t see new table styles if they configured them before
             + no chance to update the UI.
          + not the case for registry modifications (Michael)
             + UI config / gallery – done differently
          + auto-format table styles (Caolan)
             + some places we read the user & system one
             + changes have been done here recently for the icon themes
             + could work – put new styles, and read the two locations.
          + no magic bullets here (Michael)
AI:       + find a code pointer for this (Caolan)

* clang-format-ness review (Miklos)
    + any problems this week ?
    + found a few places where the suggested config is not so optimal
        + conflict between new sourcefile template & the config.
        + updated – using a 100 column limit everywhere.
    + sets of new files: the Qt5 work, and some C++ / calc unit test conversions
    + Samuel testing – should we sort includes ?
        + hidden merge conflicts with duplicate includes could be avoided
        + but issues with this too.
    + supporting multiple clang-format versions doesn’t fly
        + up-stream: if new version re-formats it in a way, then old version
          won’t re-format it back.
        + we prefer for every version to give the same result everywhere.
    => pick a single clang-format version
        + git hook enforce style only if exactly this ver is installed.
        + latest stable is 5.0.0 – lets use that; what chromium does.
    + plan to update the git hook to be even more forgiving
    + also provide pre-built binaries for this ver.
    + going reasonable well (Stephan)

* Crash Hunting (Caolan)
    + 0 import failures, 25 export failures
        + was 0/0 – but sprung a bug or two in export
        + fixed exports, a new run is progressing.
    + 7 coverity - unchanged
    + 37(+2) fuzzers * 2 sanitizers (asan and ubsan) * 1 engine (libfuzzer)
        + calc rtf and lotus 123 are latest, dif coming next
           + rtf exercises the editengine too
           + been productive.
        + finally found a png issue after 4 months of work.
        + killed an obsolete starcalc 1.0 filter that wasn’t callable.

* Crash Reporter (Xisco)
    + http://crashreport.libreoffice.org/stats/

    + http://crashreport.libreoffice.org/stats/version/5.3.6.1
        + 1911 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.3.7.2
        + 305 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.1.2
        + 4458 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.2.2
          + 2784 (last 7 days )

    + Concerned: zero 5.4.3.1 crash reports: are we just -that- good ? (Michael)
        + previous ones only got two (Xisco)
          the number of reports in RC builds is minimum.
          ie: http://crashreport.libreoffice.org/stats/version/5.4.2.1

* Hackfests & Events (Thorsten)
    + new plan from Bjoern:
       + https://skyfromme.wordpress.com/2017/08/27/hackfests-the-next-generation/
         + good suggestions from Regina
    + Hamburg – 1st new-style hackfest
         + 9th-10th December possible, if it fits.
         + just after Beta2
         + https://wiki.documentfoundation.org/Hackfests/HackfestTNG (Eike)
    + next after FOSDEM
    + Germany / France / Italy – considered for spring

* mentoring/easyhack update (Shinnok)
          committer...   1 week      1 month     3 months    12 months   
                  open      47(-15)     106(-11)    107(-11)     113(-11)
               reviews     502(-89)    1666(13)    5097(-14)   17953(160)
                merged     289(5)       964(83)    2856(122)   11159(281)
             abandoned      17(-8)       71(6)      196(6)       649(11) 
           own commits     336(-111)   1402(74)    3759(269)   13849(125)
        review commits      80(9)       269(30)     840(37)     2748(26) 
        contributor...   1 week     1 month     3 months    12 months    
                  open      14(-2)      37(-3)      38(-4)       43(-3)  
               reviews     774(-73)   2642(170)   7004(105)   22826(250) 
                merged      17(-15)     72(-16)    294(-51)    1206(-169)
             abandoned       2(0)       15(-9)      78(-19)     336(-6)  
           own commits      19(-12)     79(-9)     309(-41)     812(-110)
        review commits       0(0)        0(0)        0(0)         0(0)   
    + easyHack statistics:
       needsDevEval 31(31)   needsUXEval 0(0)   cleanup_comments 202(202)   
       total 258(258)   assigned 11(11)   open 213(213)   
    + top 5 contributors:
          Gelmini, Andrea made 23 patches in 1 month, and 174 patches in 1 year
          Johnny_M made 10 patches in 1 month, and 49 patches in 1 year
          Jim Raykowski made 5 patches in 1 month, and 10 patches in 1 year
          Ekansh Jha made 4 patches in 1 month, and 4 patches in 1 year
          Udaree Kanewala made 4 patches in 1 month, and 6 patches in 1 year
    + top 5 reviewers:
          Behrens, Thorsten made 168 review comments in 1 month, and 872 in 1 year
          Grandin, Noel made 151 review comments in 1 month, and 1365 in 1 year
          Stahl, Michael made 134 review comments in 1 month, and 1896 in 1 year
          Nabet, Julien made 84 review comments in 1 month, and 676 in 1 year

* Commit Access
    + Temporarily retiring committer status (Norbert’s proposal)
          + for those without commits after a period
          + discussed it here in the past (Miklos)
              + unclear benefit in kicking people out; did things change ?
              + but not against it
          + ok with doing it if we encourage people to contribute first (Michael)
          + “I think we've discussed that in the past, and there was consensus
            that this is reasonable (and committer status will be restored
            on request).” (Norbert’s mail)
          => come up with a list of people to mail (Norbert)

* Further gerrit lock-down to avoid non-CI’d pushes (Norbert)
    + not with the current turnaround times (Stephan)
        + wouldn’t fly.
    + at least one build-bot (Mac?) - fails on the same test (Caolan)
        + one Windows box crashes in another test – needs resolving.
        + these two tests fail every 3rd of 4th time (Jmux)
           + Mac – calc statistics, Windows – font related.
           + seems specific to those boxes.
    + windows font related in CppunitTest_vcl_complextest (Michael S)
        + was using Deja-vu font, but test didn’t have deps on that pkg.
        + fixed on master – patch in gerrit for 5.4
    + measuring build-times (Caolan)
        + no use from start to end; from patch submit to build complete
        + 3 hour build time + 6 hour wait → 9 hour delay
        + potentially wastes a day of fuzzing.
    + ideally need a full-time person to fix slaves / build-tests (Stephan)
        + a big & gnarly job fixing these corners (Michael)
        + new hardware if queues get too long etc. ? (Stephan)
    => open to the idea – but only when things work better

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    [ next step is was meeting
      2-3 names there, not all views presented (Stephan)
         + would like to hear Bjoern’s view ]

* Jenkins / CI update (Christian)
    + missing the stats.

* l10n (Sophie)
    + working quietly, and waiting for the scripts
    + Cloph didn’t get to this before his vacation.

* QA update (Xisco)

    + big drop in unconfirmed bugs
        + if last comment from QA asking for reporter input
        + triaged lots of these unconfirmed bugs, mostly automated
            + move them to NEEDINFO in this case.

    + UNCONFIRMED: 422 (-75)
        + enhancements: 49  (-15)
        + needsUXEval: 1 (+1)
        + haveBackTrace: 7 (-2)
        + needsDevAdvice: 34 (+2)
        + documentation:  2 (-1)
        + android:  17 (-3)

    + a report asking for rename soffice.bin → libreoffice.bin
        + in the past – some scripting (Kendy)
            + start was usually hard-coded to soffice.
            + need soffice for back-compat.
            + for users not a problem / UI is friendly names

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
             + Crash when switching between Calc and other LO window
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113591
                   + fun lifecycle thing from Samuel, he is working on it.

             + Impress can't play MP4 videos
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113622
                   + regression around media embedding
                   + Xisco will bisect it on Mac this week.

             + Crash click twice times on "New Theme..." in detached Gallery
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113647
                   + fixed in gtk3 but not elsewhere ?
                       + these are modal dialogs with no, or the wrong parent
                   + Patch by Caolán: https://gerrit.libreoffice.org/#/c/44550/

        + Older:
                [None]

        + Fixed:
             + CRASH: When closing the document before closing calc warning dialog
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113160
                   + Thanks to Caolan.

             + CRASH: bad dynamic_cast! after redo operation
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=108124
                   + Thanks to Fyodor Yemelyanenko and Michael S.

             + CRASH when export PDF from Print Preview
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113619
                   + Thanks to Ashod Nakashian

             + Dead keys not working with KDE4 or gen VCL backend
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=112770
                   + Thanks to Jan-Marek Glogowski

             + Inserting table in header and saving crashes
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=113597
                   + Thanks to Julien Nabet

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +141  +7 (-136) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             26
       Buovjaga                9
       V Stuart Foote          8
       Heiko Tietze            8
       eisa01                  7
       Timur                   6
       Julien Nabet            4
       Justin L                4
       Adolfo Jayme            4
       Kevin Suo               4

    + top 10 bugs reporters:
       Yousuf Philips (jay)    13
       Telesto                 7
       Christian Lehmann       5
       Gabor Kelemen           5
       Xisco Faulí             5
       Kevin Suo               3
       Jürgen Mähnß            2
       Alexey Chumakov         2
       Mike                    2
       samtuke                 2

    + top 10 bugs fixers:
       McNamara, Caolán        3
       Nabet, Julien           3
       Vajna, Miklos           2
       Justin L                2
       Faulí Tarazona, Xisco   2
       Adolfo Jayme Barrientos 2
       JoNi                    1
       Kaganski, Mike          1
       Tietze, Heiko           1

    + top 10 bugs confirmers:
       Faulí Tarazona, Xisco   58
       Buovjaga                46
       Philips, Yousuf         13
       Raal                    6
       Tietze, Heiko           6
       Henschel, Regina        6
       Dieter Praas            5
       Foote, V Stuart         5
       Budea, Áron             4
       Alex Thurgood           4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 2/47 -     4 %  (+2)
     5.2 : 2/39 -     5 %  (+0)
     5.1 : 1/35 -     2 %  (+0)
     5.0 : 2/62 -     3 %  (+0)
     4.4 : 2/76 -     2 %  (-1)
     4.3 : 5/74 -     6 %  (+0)
     4.2 : 6/134 -    4 %  (+0)
     4.1 : 3/83 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 25/258 -   9 %  (-1)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 422/1738 417/1716 410/1698 410/1669 400/1654 385/1631 380/1614 

     done by:
        Faulí Tarazona, Xisco  14
        Telesto                 8
        Budea, Áron             1
        Justin L                1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 508/2344 502/2320 494/2299 490/2265 476/2247 462/2225 461/2212 

     done by:
        Faulí Tarazona, Xisco  13
        Telesto                11
        Budea, Áron             1
        Justin L                1


* all bugs tagged with 'regression'
   + 888(+3) bugs open of 6527(+26) total 8(+1) high prio.

     done by:
        Faulí Tarazona, Xisco   9
        Telesto                 5
        Budea, Áron             2
        Buovjaga                2
        Alex Thurgood           1
        eisa01                  1
        Hosny, Khaled           1
        Raal                    1
        Németh, László          1
        Justin L                1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 4(+3)
     Impress       - 2(+0)
     graphics stack - 1(+0)
     LibreOffice   - 1(+0)
     Calc          - 0(-1)
     BASIC         - 0(-1)

   by OS:
     Linux         - 0(+0)
     Windows       - 0(+0)
     All           - 5(+1)
     Mac OS X      - 3(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 163(+6)
     Calc                     - 138(+0)
     Impress                  - 92(-1)
     Writer: docx filter      - 73(+1)
     LibreOffice              - 71(+0)
     UI                       - 49(-1)
     graphics stack           - 36(+0)
     Writer: doc filter       - 36(+0)
     Draw                     - 34(+1)
     Base                     - 30(-1)
     Writer: perf             - 29(+2)
     Writer: other filter     - 29(+3)
     Borders                  - 29(+0)
     filters and storage      - 25(+0)
     Crashes                  - 21(+2)
     Chart                    - 19(+0)
     Printing and PDF export  - 18(+0)
     BASIC                    - 16(-2)
     framework                - 5(+0)
     Linguistic               - 2(+0)
     sdk                      - 1(+0)
     Installation             - 1(+0)
     Extensions               - 1(-1)