Re: Gerrit review blocked on "Needs Code-Style"

Stephan Bergmann <sbergman -AT- redhat.com>

Wed, 8 Nov 2017 08:09:29 +0100

On 11/07/2017 11:43 PM, Thorsten Behrens wrote:

Stephan Bergmann wrote:

Why is <https://gerrit.libreoffice.org/#/c/44418/> "Suppress
loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and which I
at least cannot override via some +1 reply)?

See mail a moment ago. Missed the fact that the gerrit default submit
rule is in effect 'all labels need to be present, and at max
value'. Hopefully now fixed with a (temporary) submit filter rule (in
prolog, ugh)...

Yes, thanks, the Code-Style flag and accompanying "Needs Code-Style"

mode are completely gone again from that Gerrit change.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.