Hi,
I have no idea who has enough karma to actually do changes to the
gerrit and jenkins config, so I'm CC'ing Guilhem + Christian; do you
have an advice?
I've done the research 'what needs to be done', and I think it is no
rocket science ;-) - but also CC'ing David for sanity check.
We need:
1) Code-Style label in gerrit
   https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom
2) Gerrit trigger to trigger the style checking itself
   https://wiki.jenkins.io/display/JENKINS/Gerrit+Trigger#GerritTrigger-SetUp
   [ I guess we already have this for our Jenkins builds. ]
3) Tool that does the style checking
   The following project does that for python, but reading the code,
   it can be easily extended / changed to trigger another tool for the
   lint:
   https://github.com/astraw38/lint
   [ more in http://astraw38.github.io/gerrit-autolint/ ]
So - in case we agree to go ahead with the 'Code-Style' +1 / -1 in the
gerrit, who can actually deploy this? :-)
I think I'm happy enough to hack the 'lint' to copy there the magic
from the Miklos' git hook; the rest is hopefully ~just a setup...
[Of course, this does not implement the 'create new commit with linted
version' thing - but first things first ;-)]
All the best,
Kendy
Context
- Gerrit Code-Review +1 / -1 · Jan Holesovsky
 
   
 
  Privacy Policy |
  
Impressum (Legal Info) |
  
Copyright information: Unless otherwise specified, all text and images
  on this website are licensed under the
  
Creative Commons Attribution-Share Alike 3.0 License.
  This does not include the source code of LibreOffice, which is
  licensed under the Mozilla Public License (
MPLv2).
  "LibreOffice" and "The Document Foundation" are
  registered trademarks of their corresponding registered owners or are
  in actual use as trademarks in one or more countries. Their respective
  logos and icons are also subject to international copyright laws. Use
  thereof is explained in our 
trademark policy.