New Defects reported by Coverity Scan for LibreOffice

scan-admin -AT- coverity.com
Fri, 06 Oct 2017 00:52:33 +0000 (UTC)


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

8 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1418967:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1418967:  Uninitialized variables  (UNINIT)
/sc/source/ui/view/viewdata.cxx: 572 in ScViewData::ScViewData(ScDocShell *, ScTabViewShell *)()
566         if (pDoc)
567         {
568             SCTAB nTableCount = pDoc->GetTableCount();
569             EnsureTabDataSize(nTableCount);
570         }
571

    CID 1418967:  Uninitialized variables  (UNINIT)
    Using uninitialized value "this->nPPTY" when calling "CalcPPT".

572         CalcPPT();
573     }
574     
575     ScViewData::ScViewData( const ScViewData& rViewData ) :
576             maTabData( rViewData.maTabData ),
577             mpMarkData(new ScMarkData(*rViewData.mpMarkData)),

** CID 1418966:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/control/ctrl.cxx: 430 in Control::LogicInvalidate(const tools::Rectangle *)()


________________________________________________________________________________________________________
*** CID 1418966:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/control/ctrl.cxx: 430 in Control::LogicInvalidate(const tools::Rectangle *)()
424             // If parent is a floating window, trigger an invalidate there
425             vcl::Window* pWindow = this;
426             while (pWindow)
427             {
428                 if (pWindow->ImplIsFloatingWindow())
429                 {

    CID 1418966:  Null pointer dereferences  (FORWARD_NULL)
    Passing null pointer "dynamic_cast <FloatingWindow *>(pWindow)" to "LogicInvalidate", which 
dereferences it. (The dereference happens because this is a virtual function call.)

430                     dynamic_cast<FloatingWindow*>(pWindow)->LogicInvalidate(nullptr);
431                     return;
432                 }
433     
434                 pWindow = pWindow->GetParent();
435             }

** CID 1418965:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 2346 in BoundsProvider<int>::BoundsProvider(ScDocument *, short)()


________________________________________________________________________________________________________
*** CID 1418965:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 2346 in BoundsProvider<int>::BoundsProvider(ScDocument *, short)()
2340         long nSecondPositionPx;
2341     
2342     public:
2343         BoundsProvider(ScDocument* pD, SCTAB nT)
2344             : pDoc(pD)
2345             , nTab(nT)

    CID 1418965:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "nSecondPositionPx" is not initialized in this constructor nor in 
any functions that it calls.

2346         {}
2347     
2348         void GetStartIndexAndPosition(index_type& nIndex, long& nPosition) const
2349         {
2350             nIndex = nFirstIndex;
2351             nPosition = nFirstPositionPx;

** CID 1418964:  Incorrect expression  (COPY_PASTE_ERROR)
/sc/source/ui/view/viewdata.cxx: 221 in ScPositionHelper::getNearestByPosition(long) const()


________________________________________________________________________________________________________
*** CID 1418964:  Incorrect expression  (COPY_PASTE_ERROR)
/sc/source/ui/view/viewdata.cxx: 221 in ScPositionHelper::getNearestByPosition(long) const()
215         if (posUB == mData.begin())
216         {
217             return *posUB;
218         }
219     
220         auto posLB = std::prev(posUB);

    CID 1418964:  Incorrect expression  (COPY_PASTE_ERROR)
    "posUB" looks like a copy-paste error.

221         if (posUB == mData.end())
222         {
223             return *posLB;
224         }
225     
226         long nDiffUB = posUB->second - nPos;

** CID 1418963:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 2346 in BoundsProvider<short>::BoundsProvider(ScDocument *, short)()


________________________________________________________________________________________________________
*** CID 1418963:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 2346 in BoundsProvider<short>::BoundsProvider(ScDocument *, short)()
2340         long nSecondPositionPx;
2341     
2342     public:
2343         BoundsProvider(ScDocument* pD, SCTAB nT)
2344             : pDoc(pD)
2345             , nTab(nT)

    CID 1418963:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "nSecondPositionPx" is not initialized in this constructor nor in 
any functions that it calls.

2346         {}
2347     
2348         void GetStartIndexAndPosition(index_type& nIndex, long& nPosition) const
2349         {
2350             nIndex = nFirstIndex;
2351             nPosition = nFirstPositionPx;

** CID 1418962:  Incorrect expression  (COPY_PASTE_ERROR)
/sc/source/ui/view/viewdata.cxx: 191 in ScPositionHelper::getNearestByIndex(int) const()


________________________________________________________________________________________________________
*** CID 1418962:  Incorrect expression  (COPY_PASTE_ERROR)
/sc/source/ui/view/viewdata.cxx: 191 in ScPositionHelper::getNearestByIndex(int) const()
185         if (posUB == mData.begin())
186         {
187             return *posUB;
188         }
189     
190         auto posLB = std::prev(posUB);

    CID 1418962:  Incorrect expression  (COPY_PASTE_ERROR)
    "posUB" looks like a copy-paste error.

191         if (posUB == mData.end())
192         {
193             return *posLB;
194         }
195     
196         long nDiffUB = posUB->first - nIndex;

** CID 1418961:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 247 in ScTabView::ScTabView(vcl::Window *, ScDocShell &, 
ScTabViewShell *)()


________________________________________________________________________________________________________
*** CID 1418961:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabview.cxx: 247 in ScTabView::ScTabView(vcl::Window *, ScDocShell &, 
ScTabViewShell *)()
241         bBlockNeg( false ),
242         bBlockCols( false ),
243         bBlockRows( false ),
244         mbInlineWithScrollbar( false )
245     {
246         Init();

    CID 1418961:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "mnLOKEndHeaderCol" is not initialized in this constructor nor in 
any functions that it calls.

247     }
248     
249     void ScTabView::InitScrollBar( ScrollBar& rScrollBar, long nMaxVal )
250     {
251         rScrollBar.SetRange( Range( 0, nMaxVal ) );
252         rScrollBar.SetLineSize( 1 );

** CID 1418960:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1418960:  Uninitialized variables  (UNINIT)
/sc/source/ui/view/viewdata.cxx: 637 in ScViewData::ScViewData(const ScViewData&)()
631             bEditActive[j] = false;
632         }
633     
634         nEditEndCol = nEditStartCol = nEditCol = 0;
635         nEditEndRow = nEditRow = 0;
636         nTabStartCol = SC_TABSTART_NONE;

    CID 1418960:  Uninitialized variables  (UNINIT)
    Using uninitialized value "this->nPPTY" when calling "CalcPPT".

637         CalcPPT();
638     }
639     
640     void ScViewData::InitData( ScDocument* pDocument )
641     {
642         pDoc = pDocument;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyBsWmy31z3jNgFtBW-2BabcFic-2FeUvtdR2-2FiS-2Bnm8XDIB-2FsiQa6Cq1p7XpBRCnlAp3R-2F16hNFY-2B8yxR1jQuEQX-2FAPFwEf46hB9JfFvnOVX2chzBl5553US0l-2FN1B-2BQbpzxz5WmmPib2brsS6QTQE8PkAGjVzaZDuJxsBcLkIfIKi1c-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5lwWgMDuK-2FivqaohkU3M9kT-2Fww10Qt2GoaCJAOQCa0Wv4ijH4oV8jCt0XXa7QeAwh_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyBsWmy31z3jNgFtBW-2BabcFs-2FTipWDvE0LT-2FIxDAgKFqJdFkBdoP3HOAwufPottzWF-2F176Eo3cDkt1yLj7n9rNtpyPQyVRmOjLMj0kG9TiXSMeqc-2Fk8QoYUQDRdXzWhKEWjtfc3-2BkEMQSi2eG2KgVHWDDc1U7-2FepjwAK1BxJFMj9A-3D

Context

New Defects reported by Coverity Scan for LibreOffice · scan-admin

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.