New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

7 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1415097:  Uninitialized members  (UNINIT_CTOR)
/sw/source/core/unocore/unoframe.cxx: 1259 in SwXFrame::SwXFrame(SwFrameFormat &, FlyCntType, const 
SfxItemPropertySet *)()


________________________________________________________________________________________________________
*** CID 1415097:  Uninitialized members  (UNINIT_CTOR)
/sw/source/core/unocore/unoframe.cxx: 1259 in SwXFrame::SwXFrame(SwFrameFormat &, FlyCntType, const 
SfxItemPropertySet *)()
1253         eType(eSet),
1254         pProps(nullptr),
1255         bIsDescriptor(false),
1256         m_pCopySource(nullptr)
1257     {
1258     
> > >     CID 1415097:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "m_nDrawAspect" is not initialized in this constructor nor in any 
> > > functions that it calls.
1259     }
1260     
1261     SwXFrame::~SwXFrame()
1262     {
1263         SolarMutexGuard aGuard;
1264         delete m_pCopySource;

** CID 1415096:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/SlideBackground.cxx: 782 in 
sd::sidebar::SlideBackground::NotifyItemUpdate(unsigned short, SfxItemState, const SfxPoolItem *, 
bool)()


________________________________________________________________________________________________________
*** CID 1415096:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/SlideBackground.cxx: 782 in 
sd::sidebar::SlideBackground::NotifyItemUpdate(unsigned short, SfxItemState, const SfxPoolItem *, 
bool)()
776     
777             case SID_ATTR_PAGE_ULSPACE:
778             {
779                 const SvxLongULSpaceItem* pULItem = nullptr;
780                 if (eState >= SfxItemState::DEFAULT)
781                 {
> > >     CID 1415096:  Null pointer dereferences  (FORWARD_NULL)
> > >     Assigning: "pULItem" = "dynamic_cast <SvxLongULSpaceItem const *>(pState)".
782                     pULItem = dynamic_cast<const SvxLongULSpaceItem*>(pState);
783                     m_nPageTopMargin = pULItem->GetUpper();
784                     m_nPageBottomMargin = pULItem->GetLower();
785                     SetFieldUnit(*m_pTopMarginEdit, meFieldUnit, true);
786                     SetMetricValue(*m_pTopMarginEdit.get(), m_nPageTopMargin, meUnit);
787                     SetFieldUnit(*m_pBottomMarginEdit, meFieldUnit, true);

** CID 1415095:  Program hangs  (INFINITE_LOOP)
/vcl/qa/cppunit/timer.cxx: 322 in TimerTest::testAutoTimerStop()()


________________________________________________________________________________________________________
*** CID 1415095:  Program hangs  (INFINITE_LOOP)
/vcl/qa/cppunit/timer.cxx: 322 in TimerTest::testAutoTimerStop()()
316     
317     void TimerTest::testAutoTimerStop()
318     {
319         sal_Int32 nTimerCount = 0;
320         const sal_Int32 nMaxCount = 5;
321         AutoTimerCount aAutoTimer( 0, nTimerCount, nMaxCount );
> > >     CID 1415095:  Program hangs  (INFINITE_LOOP)
> > >     If "5 != nTimerCount" is initially true then it will remain true.
322         while ( nMaxCount != nTimerCount )
323             Application::Yield();
324         CPPUNIT_ASSERT( !aAutoTimer.IsActive() );
325         CPPUNIT_ASSERT( !Application::Reschedule() );
326     }
327     

** CID 1415093:  Program hangs  (SLEEP)


________________________________________________________________________________________________________
*** CID 1415093:  Program hangs  (SLEEP)
/vcl/source/uitest/uno/uiobject_uno.cxx: 103 in <unnamed>::ExecuteWrapper::ExecuteActionHdl(Timer 
*)()
97             }
98     
99             Scheduler::ProcessEventsToSignal(mbSignal);
100             std::unique_lock<std::mutex> lock(mMutex);
101             while (!mbSignal)
102             {
> > >     CID 1415093:  Program hangs  (SLEEP)
> > >     Call to "sleep_for" might sleep while holding lock "this->mMutex".
103                 std::this_thread::sleep_for(std::chrono::milliseconds(5));
104             }
105         }
106         delete this;
107     }
108     

** CID 1415092:  Control flow issues  (DEADCODE)
/sc/source/filter/xml/XMLTrackedChangesContext.cxx: 1409 in 
ScXMLDeletionContext::ScXMLDeletionContext(ScXMLImport &, int, const 
com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> &, 
ScXMLChangeTrackingImportHelper *)()


________________________________________________________________________________________________________
*** CID 1415092:  Control flow issues  (DEADCODE)
/sc/source/filter/xml/XMLTrackedChangesContext.cxx: 1409 in 
ScXMLDeletionContext::ScXMLDeletionContext(ScXMLImport &, int, const 
com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> &, 
ScXMLChangeTrackingImportHelper *)()
1403                     if (IsXMLToken( aIter, XML_ROW ))
1404                     {
1405                         nActionType = SC_CAT_DELETE_ROWS;
1406                     }
1407                     else if ((nToken & TOKEN_MASK) == XML_TABLE)
1408                     {
> > >     CID 1415092:  Control flow issues  (DEADCODE)
> > >     Execution cannot reach this statement: "nActionType = SC_CAT_DELETE...".
1409                         nActionType = SC_CAT_DELETE_TABS;
1410                     }
1411                     break;
1412                 case XML_ELEMENT( TABLE, XML_POSITION ):
1413                     nPosition = aIter.toInt32();
1414                     break;

** CID 1415091:  Null pointer dereferences  (REVERSE_INULL)
/sd/source/ui/view/drviews7.cxx: 1774 in sd::DrawViewShell::SetPageProperties(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1415091:  Null pointer dereferences  (REVERSE_INULL)
/sd/source/ui/view/drviews7.cxx: 1774 in sd::DrawViewShell::SetPageProperties(SfxRequest &)()
1768         bool                bScaleAll = true;
1769         Orientation         eOrientation = pPage->GetOrientation();
1770         SdPage*             pMasterPage = pPage->IsMasterPage() ? pPage : 
&static_cast<SdPage&>(pPage->TRG_GetMasterPage());
1771         bool                bFullSize = pMasterPage->IsBackgroundFullSize();
1772         sal_uInt16          nPaperBin = pPage->GetPaperBin();
1773     
> > >     CID 1415091:  Null pointer dereferences  (REVERSE_INULL)
> > >     Null-checking "pPage" suggests that it may be null, but it has already been dereferenced on 
> > > all paths leading to the check.
1774         if ( pPage && pArgs )
1775         {
1776             if ( ( nSlotId >= SID_ATTR_PAGE_COLOR ) && ( nSlotId <= SID_ATTR_PAGE_FILLSTYLE ) )
1777             {
1778                 SdrPageProperties& rPageProperties = pPage->getSdrPageProperties();
1779                 const SfxItemSet &aPageItemSet = rPageProperties.GetItemSet();

** CID 1415090:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/SlideBackground.cxx: 766 in 
sd::sidebar::SlideBackground::NotifyItemUpdate(unsigned short, SfxItemState, const SfxPoolItem *, 
bool)()


________________________________________________________________________________________________________
*** CID 1415090:  Null pointer dereferences  (FORWARD_NULL)
/sd/source/ui/sidebar/SlideBackground.cxx: 766 in 
sd::sidebar::SlideBackground::NotifyItemUpdate(unsigned short, SfxItemState, const SfxPoolItem *, 
bool)()
760     
761             case SID_ATTR_PAGE_LRSPACE:
762             {
763                 const SvxLongLRSpaceItem* pLRItem = nullptr;
764                 if (eState >= SfxItemState::DEFAULT)
765                 {
> > >     CID 1415090:  Null pointer dereferences  (FORWARD_NULL)
> > >     Assigning: "pLRItem" = "dynamic_cast <SvxLongLRSpaceItem const *>(pState)".
766                     pLRItem = dynamic_cast<const SvxLongLRSpaceItem*>(pState);
767                     m_nPageLeftMargin = pLRItem->GetLeft();
768                     m_nPageRightMargin = pLRItem->GetRight();
769                     SetFieldUnit(*m_pLeftMarginEdit, meFieldUnit, true);
770                     SetMetricValue(*m_pLeftMarginEdit.get(), m_nPageLeftMargin, meUnit);
771                     SetFieldUnit(*m_pRightMarginEdit, meFieldUnit, true);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyGL-2BRRwiRW2UNcqOcF6GvSJNPVMm0lC-2FZ3Eqh5H3nNe8D826NaQb7h4zb9K9otP-2BaY7xsyRevdPENflQjSikhI9KKlzvx6SLYVwHZW7hN37NgOr77RzAvljzNICDXt1HFLVNmJALIIfyhQhsnd8V7UMo5Ydv0nfhUDDoYCC7jejE-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyGL-2BRRwiRW2UNcqOcF6GvSBkAoSH-2B95YkBsTAzcJHEHvv9i7C6Rb2vsqeZl2lsbsuTHK-2FwLAn-2FWe2aYScA1wv-2BIgUZqjIB57a3jiZVLusszsQvh4orY4bxw-2Fv7TiVh2-2FAJ-2FNrt-2BKfXcZCn6cklIn3C10YO4VZQ1nfcioAn6Fd3BE-3D