Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


On Mon, May 22, 2017 at 10:28:03AM +0200, Miklos Vajna wrote:
Hi Tom,

On Sat, May 20, 2017 at 11:29:03AM +0200, Tomáš Chvátal <tomas.chvatal@gmail.com> wrote:
I really have no clue what the test is doing or how to fix it. The commits
introducing the tests are:
https://cgit.freedesktop.org/libreoffice/core/commit/vcl/qa/cppunit/complextext.cxx?id=62592cf1ebcc8ef381fe53855684342d963e6138
https://cgit.freedesktop.org/libreoffice/core/commit/vcl/qa/cppunit/complextext.cxx?id=9af45ef67824f3ec6e95c16e7deb005a73532d65

It can be a good idea to CC Khaled, then. :-)

The test is pretty obvious, it lays out the text and the checks the
returned character widths.

If the test is failing then either 1) your version of HarfBuzz is
returning different glyph advances which would almost certainly be a bug
in HarfBuzz, or 2) your version of DejaVu Sans have different glyph
advances but that is unlikely, or 3) VCL ended up selecting a different
font other than the one we requested for whatever reason, or 4)
something else fishy is going on in VCL.

Regards,
Khaled

Attachment: signature.asc
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.