Re: MacOS build fail "SSE4.2 instruction set not enabled" (abandonned)

I will check your patch this week on a mac / windows and linux , It's still
a hack so the proper way to solve it is like described in this
stackoverflow solution

http://stackoverflow.com/questions/11228855/header-files-
for-x86-simd-intrinsics

I used tips from
https://bidetly.io/2017/02/08/crc-part-1/

and eliminated msse4 flag from compiler command line

https://gist.github.com/mariuz/753f6fce7ebe0ac9bcf2cb26905c1cc1



On Sat, May 13, 2017 at 9:31 AM, Julien Nabet <serval2412@yahoo.fr> wrote:

> Hi,
>
> As I put on the gerrit patch, I give up with this patch because:
> - it's too complicated to modify the patch : the patching part was working
> on my Mac and it fails to apply on Jenkins Mac
> - sse4 pb. Even if it builds, LO may crash on pc which aren't compatible
> with sse4
>
> Julien
>
> On 12/05/2017 14:33, marius adrian popa wrote:
>
> Also in firebird/extern/cloop/src/tests/test1/CTest.c
>
> related to this patch
> https://gerrit.libreoffice.org/#/c/37488/6/external/
> firebird/firebird-macosx.patch.1
>
> these lines and changes are still needed for osx
>
>  #include "CalcCApi.h"
> -#include <malloc.h>
> +#include <stdlib.h>
>  #include <stdio.h>
>
> now build fails https://ci.libreoffice.org/job/lo_gerrit/11317/Config=
> macosx_clang_dbgutil/
>
> On Fri, May 12, 2017 at 1:10 PM, Tomaž Vajngerl <quikee@gmail.com> wrote:
>
> > Hi,
> >
> > On Fri, May 12, 2017 at 11:05 AM, marius adrian popa <mapopa@gmail.com>
> > wrote:
> > > Known issue in Firebird 3.0.x
> > >
> > > http://firebird.1100200.n4.nabble.com/std-c-11-added-to-CXXF
> > LAGS-in-3-0-on-linux-td4645224.html
> > > introduced by this commit
> > >
> > > https://github.com/FirebirdSQL/firebird/commit/52d9a05a0f3d
> >
> > They would need to add something like "%/CRC32C.o: COMMON_FLAGS +=
> > -msse4" to prefix.darwin too (clang should have compatible switches)
> >
> > For Windows It is complicated as it depends if the particular VS
> > version supports the instructions or not, but you need to add some
> > compile switch too...
> >
> > That's only for compiler - in addition you also need run-time
> > detection, but I see this is already covered by SSE4_2Supported()
> > method.
> >
> > Regards, Tomaž