New Defects reported by Coverity Scan for LibreOffice

scan-admin -AT- coverity.com
Fri, 12 May 2017 00:07:50 -0700


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
37 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1406101:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/doc/doclay.cxx: 800 in lcl_InsertLabel(SwDoc &, SwTextFormatColls *, 
SwUndoInsertLabel *, SwLabelType, const rtl::OUString &, const rtl::OUString &, const rtl::OUString 
&, bool, unsigned short, unsigned long, const rtl::OUString &, bool)()


________________________________________________________________________________________________________
*** CID 1406101:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/doc/doclay.cxx: 800 in lcl_InsertLabel(SwDoc &, SwTextFormatColls *, 
SwUndoInsertLabel *, SwLabelType, const rtl::OUString &, const rtl::OUString &, const rtl::OUString 
&, bool, unsigned short, unsigned long, const rtl::OUString &, bool)()
794                     if ( RndStdIds::FLY_AS_CHAR == rAnchor.GetAnchorId() )
795                     {
796                         const SwPosition *pPos = rAnchor.GetContentAnchor();
797                         SwTextNode *pTextNode = pPos->nNode.GetNode().GetTextNode();
798                         OSL_ENSURE( pTextNode->HasHints(), "Missing FlyInCnt-Hint." );
799                         const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406101:  Null pointer dereferences  (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

800                         SwTextAttr * const pHint =
801                             pTextNode->GetTextAttrForCharAt(nIdx, RES_TXTATR_FLYCNT);
802     
803                         OSL_ENSURE( pHint && pHint->Which() == RES_TXTATR_FLYCNT,
804                                     "Missing FlyInCnt-Hint." );
805                         OSL_ENSURE( pHint && pHint->GetFlyCnt().GetFrameFormat() == pOldFormat,

** CID 1406100:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/undo/undobj1.cxx: 558 in SwUndoSetFlyFormat::UndoImpl(sw::UndoRedoContext &)()


________________________________________________________________________________________________________
*** CID 1406100:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/undo/undobj1.cxx: 558 in SwUndoSetFlyFormat::UndoImpl(sw::UndoRedoContext &)()
552                     // also the format. To prevent that, first detach the
553                     // connection between attribute and format.
554                     const SwPosition *pPos = rOldAnch.GetContentAnchor();
555                     SwTextNode *pTextNode = pPos->nNode.GetNode().GetTextNode();
556                     OSL_ENSURE( pTextNode->HasHints(), "Missing FlyInCnt-Hint." );
557                     const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406100:  Null pointer dereferences  (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

558                     SwTextAttr * pHint = pTextNode->GetTextAttrForCharAt(
559                             nIdx, RES_TXTATR_FLYCNT );
560                     OSL_ENSURE( pHint && pHint->Which() == RES_TXTATR_FLYCNT,
561                                 "Missing FlyInCnt-Hint." );
562                     OSL_ENSURE( pHint && pHint->GetFlyCnt().GetFrameFormat() == pFrameFormat,
563                                 "Wrong TextFlyCnt-Hint." );

** CID 1406099:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/undo/unattr.cxx: 464 in SwUndoFormatAttr::RestoreFlyAnchor(sw::UndoRedoContext &)()


________________________________________________________________________________________________________
*** CID 1406099:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/undo/unattr.cxx: 464 in SwUndoFormatAttr::RestoreFlyAnchor(sw::UndoRedoContext &)()
458             // To prevent that, first detach the connection between attribute and
459             // format.
460             const SwPosition *pPos = rOldAnch.GetContentAnchor();
461             SwTextNode *pTextNode = static_cast<SwTextNode*>(&pPos->nNode.GetNode());
462             OSL_ENSURE( pTextNode->HasHints(), "Missing FlyInCnt-Hint." );
463             const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406099:  Null pointer dereferences  (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

464             SwTextAttr * const pHint =
465                 pTextNode->GetTextAttrForCharAt( nIdx, RES_TXTATR_FLYCNT );
466             OSL_ENSURE( pHint && pHint->Which() == RES_TXTATR_FLYCNT,
467                         "Missing FlyInCnt-Hint." );
468             OSL_ENSURE( pHint && pHint->GetFlyCnt().GetFrameFormat() == pFrameFormat,
469                         "Wrong TextFlyCnt-Hint." );

** CID 1406098:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/doc/doclay.cxx: 1117 in lcl_InsertDrawLabel(SwDoc &, SwTextFormatColls *, 
SwUndoInsertLabel *, SwDrawFrameFormat *, const rtl::OUString &, const rtl::OUString &, const 
rtl::OUString &, unsigned short, const rtl::OUString &, SdrObject &)()


________________________________________________________________________________________________________
*** CID 1406098:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/core/doc/doclay.cxx: 1117 in lcl_InsertDrawLabel(SwDoc &, SwTextFormatColls *, 
SwUndoInsertLabel *, SwDrawFrameFormat *, const rtl::OUString &, const rtl::OUString &, const 
rtl::OUString &, unsigned short, const rtl::OUString &, SdrObject &)()
1111         if ( RndStdIds::FLY_AS_CHAR == rAnchor.GetAnchorId() )
1112         {
1113             const SwPosition *pPos = rAnchor.GetContentAnchor();
1114             SwTextNode *pTextNode = pPos->nNode.GetNode().GetTextNode();
1115             OSL_ENSURE( pTextNode->HasHints(), "Missing FlyInCnt-Hint." );
1116             const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406098:  Null pointer dereferences  (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

1117             SwTextAttr * const pHint =
1118                 pTextNode->GetTextAttrForCharAt( nIdx, RES_TXTATR_FLYCNT );
1119     
1120     #if OSL_DEBUG_LEVEL > 0
1121             OSL_ENSURE( pHint && pHint->Which() == RES_TXTATR_FLYCNT,
1122                         "Missing FlyInCnt-Hint." );

** CID 1406097:    (NULL_RETURNS)
/sw/source/core/unocore/unodraw.cxx: 1144 in SwXShape::setPropertyValue(const rtl::OUString &, 
const com::sun::star::uno::Any &)()
/sw/source/core/unocore/unodraw.cxx: 1272 in SwXShape::setPropertyValue(const rtl::OUString &, 
const com::sun::star::uno::Any &)()


________________________________________________________________________________________________________
*** CID 1406097:    (NULL_RETURNS)
/sw/source/core/unocore/unodraw.cxx: 1144 in SwXShape::setPropertyValue(const rtl::OUString &, 
const com::sun::star::uno::Any &)()
1138                                     //Tbis removes the frame format too.
1139                                     //To prevent this the connection between format and 
attribute has to be broken before.
1140                                     const SwPosition *pPos = aAnchor.GetContentAnchor();
1141                                     SwTextNode *pTextNode = 
pPos->nNode.GetNode().GetTextNode();
1142                                     SAL_WARN_IF( !pTextNode->HasHints(), "sw.uno", "Missing 
FlyInCnt-Hint." );
1143                                     const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406097:    (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

1144                                     SwTextAttr * const pHint =
1145                                         pTextNode->GetTextAttrForCharAt(
1146                                             nIdx, RES_TXTATR_FLYCNT );
1147                                     SAL_WARN_IF( !pHint || pHint->Which() != RES_TXTATR_FLYCNT,
1148                                                 "sw.uno", "Missing FlyInCnt-Hint." );
1149                                     SAL_WARN_IF( !pHint || pHint->GetFlyCnt().GetFrameFormat() 
!= pFormat,
/sw/source/core/unocore/unodraw.cxx: 1272 in SwXShape::setPropertyValue(const rtl::OUString &, 
const com::sun::star::uno::Any &)()
1266                                 //Tbis removes the frame format too.
1267                                 //To prevent this the connection between format and attribute 
has to be broken before.
1268                                 const SwPosition *pPos = rOldAnchor.GetContentAnchor();
1269                                 SwTextNode *pTextNode = pPos->nNode.GetNode().GetTextNode();
1270                                 SAL_WARN_IF( !pTextNode->HasHints(), "sw.uno", "Missing 
FlyInCnt-Hint." );
1271                                 const sal_Int32 nIdx = pPos->nContent.GetIndex();

    CID 1406097:    (NULL_RETURNS)
    Assigning: "pHint" = null return value from "GetTextAttrForCharAt".

1272                                 SwTextAttr * const pHint =
1273                                     pTextNode->GetTextAttrForCharAt(
1274                                         nIdx, RES_TXTATR_FLYCNT );
1275                                 SAL_WARN_IF( !pHint || pHint->Which() != RES_TXTATR_FLYCNT,
1276                                             "sw.uno", "Missing FlyInCnt-Hint." );
1277                                 SAL_WARN_IF( !pHint || pHint->GetFlyCnt().GetFrameFormat() != 
pFlyFormat,


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyzjiPzEqiXE6cvpvyf4ulf4EgRlKfZXFPmaASxIzddjQVjgsOCdu-2FV1Mn2sD4-2FtkokrYnyKBGrwgJiq4ZcCkVTEVv3mxn4PwxP3TGuDZJhiwdg26uh2Frwnqnvejj5-2FRu13UzT0t-2BTRyXRthrY-2BN9m29y6zwln8h3HrmYHH18qMg-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyzjiPzEqiXE6cvpvyf4ulf-2Bupaj1Q3no-2FmDydEoFlC3orbhDEC7h1rfdzblKTAbzV-2FpDifhesCsSs5NpCSb3FTZNYq8JAmavFOzHZxn6FW-2FvQ-2BoMe7RcUsiQTNhmta4Dt95lOuntWu-2F-2BRH050ge0fRuCUMPjworBZb-2BvQhP7jkFI-3D

Context

New Defects reported by Coverity Scan for LibreOffice · scan-admin

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.