Re: [Libreoffice-commits] core.git: osl: remove comment cruft, whitespace cleanup of process.cxx

On 05/06/2017 08:27 PM, Chris Sherlock wrote:
> commit d0f3d5eb384d08b5c3a6995dadeacce2203f8f47
> Author: Chris Sherlock <chris.sherlock79@gmail.com>
> Date:   Sun May 7 04:22:16 2017 +1000
>
>      osl: remove comment cruft, whitespace cleanup of process.cxx
>      
>      Change-Id: I9609306dfe70595e67ee6100ce236e849e7a3eca
>
> diff --git a/sal/osl/unx/process.cxx b/sal/osl/unx/process.cxx
> index 52b676ab8827..a9fb2986dc4f 100644
> --- a/sal/osl/unx/process.cxx
> +++ b/sal/osl/unx/process.cxx
> @@ -108,12 +108,6 @@ oslProcessError SAL_CALL osl_psz_executeProcess(sal_Char *pszImageName,
>                                                   oslFileHandle *pOutputRead,
>                                                   oslFileHandle *pErrorRead );
>   
> -/******************************************************************************
> - *
> - *                  Functions for starting a process
> - *
> - *****************************************************************************/
> -
>   extern "C" {
>   
>   static void ChildStatusProc(void *pData)
> @@ -364,9 +358,9 @@ static void ChildStatusProc(void *pData)
>               if (stdOutput[0] != -1) close( stdOutput[0] );
>               if (stdError[0] != -1) close( stdError[0] );
>   
> -            //if pid > 0 then a process was created, even if it later failed
> -            //e.g. bash searching for a command to execute, and we still
> -            //need to clean it up to avoid "defunct" processes
> +            /* if pid > 0 then a process was created, even if it later failed
> +               e.g. bash searching for a command to execute, and we still
> +               need to clean it up to avoid "defunct" processes */

Historically, this and similar files had been C source, written with 
pre-C99 style /*...*/ comments (out of necessity or habit).  But I see 
no good reason to introduce needless revision history thrash here, by 
changing acceptably-looking comments back to pre-C99 style.