Re: INVALID_POOL_ITEM in sfx2::sidebar::ControllerItem::ItmeUpdateReceiverInterface::NotifyItemUpdate

On 04/14/2017 01:47 PM, Caolán McNamara wrote:
> sfx2/source/control/bindings.cxx:1271:20 is
>   rCache.SetState( SfxItemState::DONTCARE, INVALID_POOL_ITEM );
> and the common pattern seems to be to only look at the payload of
> states >= ::DEFAULT. In this consumer that's equivalent to having
> bDefaultOrSet set and indeed in that handler we only dereference the
> casted pState if that's set, so if we defer the cast to that point too
> I presume the problem goes away. I've pushed that as
> 9a27902bbcfc7455d068167d8abc9645e2687ba1 so we'll find out if that
> helps

Yes, thanks, that apparently fixed it, as can be seen by a failing 
<http://ci.libreoffice.org/job/lo_ubsan/508/> vs. fixed 
<http://ci.libreoffice.org/job/lo_ubsan/509/>.