New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/core/tool/chartlis.cxx: 152 in ScChartListener::~ScChartListener()()


________________________________________________________________________________________________________
*** CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/core/tool/chartlis.cxx: 152 in ScChartListener::~ScChartListener()()
146                 pRefMgr->addLinkListener(*itr, mpExtRefListener.get());
147                 mpExtRefListener->addFileId(*itr);
148             }
149         }
150     }
151     
> > >     CID 1402154:  Error handling issues  (UNCAUGHT_EXCEPT)
> > >     An exception of type "com::sun::star::uno::DeploymentException" is thrown but the throw 
> > > list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which 
> > > usually calls terminate().
152     ScChartListener::~ScChartListener()
153     {
154         if ( HasBroadcaster() )
155             EndListeningTo();
156         delete pUnoData;
157     

** CID 1402153:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 117 in BitmapReadAccess::BitmapReadAccess(Bitmap &)()


________________________________________________________________________________________________________
*** CID 1402153:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 117 in BitmapReadAccess::BitmapReadAccess(Bitmap &)()
111     BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
112                 BitmapInfoAccess( rBitmap, BitmapAccessMode::Read ),
113                 mFncGetPixel    ( nullptr ),
114                 mFncSetPixel    ( nullptr )
115     {
116         ImplInitScanBuffer( rBitmap );
> > >     CID 1402153:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "mpScanBuf" is not initialized in this constructor nor in any 
> > > functions that it calls.
117     }
118     
119     BitmapReadAccess::~BitmapReadAccess()
120     {
121     }
122     

** CID 1402152:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 109 in BitmapReadAccess::BitmapReadAccess(Bitmap &, BitmapAccessMode)()


________________________________________________________________________________________________________
*** CID 1402152:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/bmpacc.cxx: 109 in BitmapReadAccess::BitmapReadAccess(Bitmap &, BitmapAccessMode)()
103     BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap, BitmapAccessMode nMode ) :
104                 BitmapInfoAccess( rBitmap, nMode ),
105                 mFncGetPixel    ( nullptr ),
106                 mFncSetPixel    ( nullptr )
107     {
108         ImplInitScanBuffer( rBitmap );
> > >     CID 1402152:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "mpScanBuf" is not initialized in this constructor nor in any 
> > > functions that it calls.
109     }
110     
111     BitmapReadAccess::BitmapReadAccess( Bitmap& rBitmap ) :
112                 BitmapInfoAccess( rBitmap, BitmapAccessMode::Read ),
113                 mFncGetPixel    ( nullptr ),
114                 mFncSetPixel    ( nullptr )

** CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 3142 in ScDocShellModificator::~ScDocShellModificator()()


________________________________________________________________________________________________________
*** CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
/sc/source/ui/docshell/docsh.cxx: 3142 in ScDocShellModificator::~ScDocShellModificator()()
3136         bAutoCalcShellDisabled = rDoc.IsAutoCalcShellDisabled();
3137         bIdleEnabled = rDoc.IsIdleEnabled();
3138         rDoc.SetAutoCalcShellDisabled( true );
3139         rDoc.EnableIdle(false);
3140     }
3141     
> > >     CID 1402151:  Error handling issues  (UNCAUGHT_EXCEPT)
> > >     An exception of type "mdds::general_error" is thrown but the throw list "throw()" doesn't 
> > > allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
3142     ScDocShellModificator::~ScDocShellModificator()
3143     {
3144         ScDocument& rDoc = rDocShell.GetDocument();
3145         rDoc.SetAutoCalcShellDisabled( bAutoCalcShellDisabled );
3146         if ( !bAutoCalcShellDisabled && rDocShell.IsDocumentModifiedPending() )
3147             rDocShell.SetDocumentModified();    // last one shuts off the lights

** CID 1402150:  API usage errors  (INVALIDATE_ITERATOR)
/cui/source/options/treeopt.cxx: 2003 in OfaTreeOptionsDialog::LoadNodes(Module *, const 
rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1402150:  API usage errors  (INVALIDATE_ITERATOR)
/cui/source/options/treeopt.cxx: 2003 in OfaTreeOptionsDialog::LoadNodes(Module *, const 
rtl::OUString &)()
1997                 for ( VectorOfNodes::size_type j = 0; j < aNodeList.size(); ++j )
1998                 {
1999                     OptionsNode* pNode = aNodeList[j];
2000                     if ( pNode->m_sId == sNodeId )
2001                     {
2002                         aOutNodeList.push_back( pNode );
> > >     CID 1402150:  API usage errors  (INVALIDATE_ITERATOR)
> > >     Using invalid iterator "std::vector<OptionsNode *, std::allocator<OptionsNode *> 
> > > > ::const_iterator(aNodeList.begin() + j)".
2003                         aNodeList.erase( aNodeList.begin() + j );
2004                         break;
2005                     }
2006                 }
2007             }
2008     

** CID 1402149:  Null pointer dereferences  (FORWARD_NULL)
/sw/qa/extras/ww8import/ww8import.cxx: 85 in testTdf105570::verify()()


________________________________________________________________________________________________________
*** CID 1402149:  Null pointer dereferences  (FORWARD_NULL)
/sw/qa/extras/ww8import/ww8import.cxx: 85 in testTdf105570::verify()()
79           *
80           * The document have three tables with three rows.
81           * Table 1 has { 1, 0, 0 } values of the "repeat as header row" property for each row
82           * Table 2 has { 1, 1, 0 }
83           * Table 3 has { 0, 1, 1 }
84           ****/
> > >     CID 1402149:  Null pointer dereferences  (FORWARD_NULL)
> > >     Assigning: "pTextDoc" = "dynamic_cast <SwXTextDocument *>(this->mxComponent.get())".
85         SwXTextDocument* pTextDoc     = dynamic_cast<SwXTextDocument*>(mxComponent.get());
86         SwDoc*           pDoc         = pTextDoc->GetDocShell()->GetDoc();
87         SwWrtShell*      pWrtShell    = pDoc->GetDocShell()->GetWrtShell();
88         SwShellCursor*   pShellCursor = pWrtShell->getShellCursor( false );
89         SwNodeIndex      aIdx         = SwNodeIndex( pShellCursor->Start()->nNode );
90     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy1U3n4Dt76E1fSJomot2BqmtWMbd4KgVIKXwxcB2mcFexG-2FWUL3dFMB61A5LKdTtAmgiR0rA5p7mGZ7GVU-2B4xPnSOdNyTdLi1ECE6CQ0VnsoeupGqrPiLW0yiFy8kBQLn-2Fgwt7CtEY6pR4KlCJxj1ae9-2FbKrts8yz-2FhEUre02YgY-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy1U3n4Dt76E1fSJomot2Bqqk5k2qSm144zJWIJICam-2Fb21urdJbY9L91BnbPADZfKTSFl0U2RD4N4X9wE5eVT4Gwxs9TGNvwex9VGovH6UuGuMfk6KRyBvsAPMiSkAmJrpRvpNS0kUocOj63KBDb16mJZNC4EI47YA5XthB2bsY0-3D