Re: how to check if my local copy of translations is really up-to-date?

Hi Christian, *,

Le 24.02.2017 13:09, Christian Lohmaier a écrit :
> Hi  Jean-Baptiste,  *,
>
> On Sun, Feb 19, 2017 at 9:38 AM, Jean-Baptiste Faure
> <jbfaure@libreoffice.org> wrote:
> > Is there a mean to check if the command "./g pull -r" did its job 
> > correctly,
> > that is if the local translations subdirectory is really up-to-date.
>
> git submodule status
>
> if that has any character other than space before the git-hash, then
> the state of the submodule is not what the core module expects.

Thank you for this command. I did that and my local copy is ok.

> > I did ./g fetch without change in the local translations subdirectory.
>
> fetch won't touch your checkout.
>
> > [1] https://bugs.documentfoundation.org/show_bug.cgi?id=106082
>
> Best way to go for those kind of things is:
> A) use key-ID language of the branch to see what keyID the string  in
> question has
> B) check in pootle whether the string using that keyID is actually 
> translated
> C) check timeline of the string in pootle, it might have been
> translated after the translations have been added to the repository
> D) git grep in translations submodule for the string/look in po files
> in translations repo whether translation is in there

I did that to check that the string is translated in Pootle and that the 
translation is in the po files in my local copy.

> In this case, the translation is in the translations repo, and is also
> applied for my build.
>
> So to be  clear:
> source/fr/svx/source/stbctrls.po has the translation in your checkout,
> but in LibreOffice UI it is still untranslated?

Yes. The bug 106082 has been confirmed on LO 5.2.6.1, at least for 
French and Italian.

Today I bisected the bug on the 5.2 branch (less commits to test), and 
the first bad commit is:

commit 3687612a93813449cfc68ce5ece3b785560b2e58
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Fri Feb 3 08:35:59 2017 +0100

    tdf#105707 PPTX import: warn when SmartArt is missing DrawingML 
fallback

    By the time DiagramGraphicDataContext::onCreateContext() completes, 
we
    know if there will be a DrawingML fallback for the SmartArt (called
    ExtDrawing in the code) or not.

    Warn about this case once at the end of the import when in 
interactive
    mode. Headless mode silently ignores the warning as expected.

    (cherry picked from commit ae828495be9c2ac5fdb4c1747ed7bdd51e5d87a7)

    Conflicts:
        include/svx/dialogs.hrc
        oox/source/core/xmlfilterbase.cxx

    Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d
    Reviewed-on: https://gerrit.libreoffice.org/33873
    Tested-by: Jenkins <ci@libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm@redhat.com>
    Tested-by: Caolán McNamara <caolanm@redhat.com>

My C++ (non-)knowledge does not allow me to detect what change in this 
commit triggered the bug.

Best regards.
JBF