Hi Stephan,
On Tue, 2017-02-21 at 10:14 +0100, Stephan Bergmann wrote:
Any numbers that show that these complications of the code are worth
it?
TBH I don't know that much about profiling, but when I tested just the
GetGlobalAcceleratorConfiguration function, the cpu time I got was
around 30% of what was before. Also it worth mentioning that this
technique also used in other places in the code base, e.g.
http://opengrok.libreoffice.org/xref/core/framework/source/uielement/su
btoolbarcontroller.cxx#199
http://opengrok.libreoffice.org/xref/core/sfx2/source/appl/imagemgr.cxx
#140
when the latter is of exact the same use case.
Are these complications really worth it? I don't have a definite
answer, as I doubt that the difference can be noticed on a modern hw
(unlike GlobalAcceleratorConfiguration that I changed in the other
commit, which was a real problem).
Maxim
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.