Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Am 27.01.2017 um 07:07 schrieb David Ostrovsky:
It would be also cool, if you could look into new and shiny gerrit UI,
based on JavaScript Polymer framework, and provide feedback. You can
see the new UI in action upstream by switching in footer to new UI.
Only change screen is implemented for now. All diffs on one page is
already implemented:

https://gerrit-review.googlesource.com/

Generally I like the new UI - if just for the - per file expandable -
inline diff :-) But switching the "info" and "commit message" frames
produces a lot of unused / white area on the right, and uses more
precious vertical space.
Especially since the left "info" frame doesn't expand much horizontally,
so can't / won't display multiple reviewers in one row, but instead the
commit message expands, which almost ever has a fixed maximum width.

I first had a look at

https://gerrit-review.googlesource.com/c/95455/?polygerrit=1

but it's probably event better to see, if you check

https://gerrit-review.googlesource.com/c/94813/?polygerrit=1

Now there is some of the white space used by the relation chain.
Just decrease the browser horizontally.

To save some vertical space it would also help to merge Reviewers,
Code-Review and Verified into a table, so this won't duplicate name
lists, like:

Reviewer | Verified | Code
Me       |   +1     |  +1
You      |          |  -1


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.