Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


On 18.01.2017 14:03, Stephan Bergmann wrote:
For better or worse, dynamic exception specifications (the "throw (ex1, 
ex2, ex3)" part of function declarations) were deprecated in C++11 and 
will be removed from the language entirely in C++17.  (The new 
alternative being 'noexcept'.)

Consequently, (current trunk builds towards) GCC 7 issues a -Wdeprecated 
warning for each dynamic exception specification it encounters.  Which 
for us means that we'll need to come up with a plan for the exception 
specifications across the LO code base, short of bluntly disabling all 
kind of -Wdeprecated for GCC 7---which is hardly what we want to do 
going forward.

There are four cases to consider:

A  URE interface include files.

B  Generated UNO API include files.

C  "Plain" LO internal code.

D  "External" code where LIBO_INTERNAL_ONLY is not defined: SDK 
examples, extension code.

we already do release builds with -fno-enforce-eh-specs, while MSVC
just ignores the exception specifications, and only --enable-dbgutil
turns them on with GCC and clang, so there should be no difference for
release builds.

currently the exception specifications effectively serve as an assertion
mechanism where an API implementation fails the assertion if it throws
an exception that it isn't documented to throw.

this happens from time to time, so i wonder what replacement you have in
mind for the current 1000s of assertions to quickly and easily detect
such bugs.

Instead of coming up with new macros (after we've successfully removed 
SAL_THROW in the past) to hide dynamic exception specifications behind, 
my proposal is to remove them completely from all of the code (on 
current master towards LO 5.4).



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.