Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index 


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
525 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1398822:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
/qadevOOo/runner/helper/CfgParser.java: 60 in 
helper.CfgParser.getIniParameters(lib.TestParameters)()


________________________________________________________________________________________________________
*** CID 1398822:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
/qadevOOo/runner/helper/CfgParser.java: 60 in 
helper.CfgParser.getIniParameters(lib.TestParameters)()
54                 Enumeration<Object> cfgEnum = cfg.keys();
55                 while (cfgEnum.hasMoreElements())
56                 {
57                     String pName = (String) cfgEnum.nextElement();
58                     Object pValue = cfg.getProperty(pName);
59     

    CID 1398822:  FindBugs: Dodgy code  (FB.BC_VACUOUS_INSTANCEOF)
    instanceof will always return true for all nonnull values, since all String are instances 
of String.

60                     if (pValue instanceof String)
61                     {
62                         pValue = ((String) pValue).trim();
63                     }
64     
65                     param.put(pName.trim(), pValue);

** CID 1398821:  Error handling issues  (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 202 in 
filter::config::FilterCache::load(filter::config::FilterCache::EFillState)()


________________________________________________________________________________________________________
*** CID 1398821:  Error handling issues  (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 202 in 
filter::config::FilterCache::load(filter::config::FilterCache::EFillState)()
196         // But here we can check against the later changes...
197         impl_validateAndOptimize();
198         // <- SAFE ----------------------------------
199     }
200     
201     

    CID 1398821:  Error handling issues  (UNCAUGHT_EXCEPT)
    An exception of type "std::length_error" is thrown but the throw list 
"throw(com::sun::star::uno::Exception)" doesn't allow it to be thrown. This will cause a call 
to unexpected() which usually calls terminate().

202     void FilterCache::load(EFillState eRequired)
203         throw(css::uno::Exception)
204     {
205         // SAFE -> ----------------------------------
206         ::osl::ResettableMutexGuard aLock(m_aLock);
207     

** CID 1398820:    (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 1406 in 
filter::config::FilterCache::impl_loadSet(const 
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, 
filter::config::FilterCache::EItemType, filter::config::FilterCache::EReadOption, 
std::unordered_map<rtl::OUString, filter::config::CacheItem, rtl::OUStringHash, 
std::equal_to<rtl::OUString>, std::allocator<std::pair<const rtl::OUString, 
filter::config::CacheItem>>> *)()
/filter/source/config/cache/filtercache.cxx: 1406 in 
filter::config::FilterCache::impl_loadSet(const 
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, 
filter::config::FilterCache::EItemType, filter::config::FilterCache::EReadOption, 
std::unordered_map<rtl::OUString, filter::config::CacheItem, rtl::OUStringHash, 
std::equal_to<rtl::OUString>, std::allocator<std::pair<const rtl::OUString, 
filter::config::CacheItem>>> *)()


________________________________________________________________________________________________________
*** CID 1398820:    (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 1406 in 
filter::config::FilterCache::impl_loadSet(const 
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, 
filter::config::FilterCache::EItemType, filter::config::FilterCache::EReadOption, 
std::unordered_map<rtl::OUString, filter::config::CacheItem, rtl::OUStringHash, 
std::equal_to<rtl::OUString>, std::allocator<std::pair<const rtl::OUString, 
filter::config::CacheItem>>> *)()
1400         impl_validateAndOptimize();
1401     
1402         // <- SAFE
1403     }
1404     
1405     

    CID 1398820:    (UNCAUGHT_EXCEPT)
    An exception of type "std::length_error" is thrown but the throw list 
"throw(com::sun::star::uno::Exception)" doesn't allow it to be thrown. This will cause a call 
to unexpected() which usually calls terminate().

1406     void FilterCache::impl_loadSet(const css::uno::Reference< css::container::XNameAccess >& 
xConfig,
1407                                          EItemType                                           
eType  ,
1408                                          EReadOption                                         
eOption,
1409                                          CacheItemList*                                      
pCache )
1410         throw(css::uno::Exception)
1411     {
/filter/source/config/cache/filtercache.cxx: 1406 in 
filter::config::FilterCache::impl_loadSet(const 
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &, 
filter::config::FilterCache::EItemType, filter::config::FilterCache::EReadOption, 
std::unordered_map<rtl::OUString, filter::config::CacheItem, rtl::OUStringHash, 
std::equal_to<rtl::OUString>, std::allocator<std::pair<const rtl::OUString, 
filter::config::CacheItem>>> *)()
1400         impl_validateAndOptimize();
1401     
1402         // <- SAFE
1403     }
1404     
1405     

    CID 1398820:    (UNCAUGHT_EXCEPT)
    An exception of type "std::length_error" is thrown but the throw list 
"throw(com::sun::star::uno::Exception)" doesn't allow it to be thrown. This will cause a call 
to unexpected() which usually calls terminate().

1406     void FilterCache::impl_loadSet(const css::uno::Reference< css::container::XNameAccess >& 
xConfig,
1407                                          EItemType                                           
eType  ,
1408                                          EReadOption                                         
eOption,
1409                                          CacheItemList*                                      
pCache )
1410         throw(css::uno::Exception)
1411     {

** CID 1398819:  Error handling issues  (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 1713 in 
filter::config::FilterCache::impl_loadItemOnDemand(filter::config::FilterCache::EItemType, const 
rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1398819:  Error handling issues  (UNCAUGHT_EXCEPT)
/filter/source/config/cache/filtercache.cxx: 1713 in 
filter::config::FilterCache::impl_loadItemOnDemand(filter::config::FilterCache::EItemType, const 
rtl::OUString &)()
1707         }
1708     
1709         return aItem;
1710     }
1711     
1712     

    CID 1398819:  Error handling issues  (UNCAUGHT_EXCEPT)
    An exception of type "std::length_error" is thrown but the throw list 
"throw(com::sun::star::uno::Exception)" doesn't allow it to be thrown. This will cause a call 
to unexpected() which usually calls terminate().

1713     CacheItemList::iterator FilterCache::impl_loadItemOnDemand(      EItemType        eType,
1714                                                                const OUString& sItem)
1715         throw(css::uno::Exception)
1716     {
1717         CacheItemList*                              pList   = nullptr;
1718         css::uno::Reference< css::uno::XInterface > xConfig    ;

** CID 1398818:  Integer handling issues  (SIGN_EXTENSION)
/svx/source/xoutdev/xattrbmp.cxx: 121 in XOBitmap::Array2Bitmap()()


________________________________________________________________________________________________________
*** CID 1398818:  Integer handling issues  (SIGN_EXTENSION)
/svx/source/xoutdev/xattrbmp.cxx: 121 in XOBitmap::Array2Bitmap()()
115     
116         // create bitmap
117         for( sal_uInt16 i = 0; i < nLines; i++ )
118         {
119             for( sal_uInt16 j = 0; j < nLines; j++ )
120             {

    CID 1398818:  Integer handling issues  (SIGN_EXTENSION)
    Suspicious implicit sign extension: "nLines" with type "unsigned short" (16 bits, unsigned) 
is promoted in "j + i * nLines" to type "int" (32 bits, signed), then sign-extended to type 
"unsigned long" (64 bits, unsigned).  If "j + i * nLines" is greater than 0x7FFFFFFF, the upper 
bits of the result will all be 1.

121                 if( pPixelArray[ j + i * nLines ] == 0 )
122                     pVDev->DrawPixel( Point( j, i ), aBckgrColor );
123                 else
124                     pVDev->DrawPixel( Point( j, i ), aPixelColor );
125             }
126         }

** CID 1398817:  Integer handling issues  (SIGN_EXTENSION)
/svx/source/xoutdev/xattrbmp.cxx: 121 in XOBitmap::Array2Bitmap()()


________________________________________________________________________________________________________
*** CID 1398817:  Integer handling issues  (SIGN_EXTENSION)
/svx/source/xoutdev/xattrbmp.cxx: 121 in XOBitmap::Array2Bitmap()()
115     
116         // create bitmap
117         for( sal_uInt16 i = 0; i < nLines; i++ )
118         {
119             for( sal_uInt16 j = 0; j < nLines; j++ )
120             {

    CID 1398817:  Integer handling issues  (SIGN_EXTENSION)
    Suspicious implicit sign extension: "i" with type "unsigned short" (16 bits, unsigned) is 
promoted in "j + i * nLines" to type "int" (32 bits, signed), then sign-extended to type 
"unsigned long" (64 bits, unsigned).  If "j + i * nLines" is greater than 0x7FFFFFFF, the upper 
bits of the result will all be 1.

121                 if( pPixelArray[ j + i * nLines ] == 0 )
122                     pVDev->DrawPixel( Point( j, i ), aBckgrColor );
123                 else
124                     pVDev->DrawPixel( Point( j, i ), aPixelColor );
125             }
126         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyB8iAsgD14RdcQ2Fj1EJaTdhv4gn0IPynj9ysh6gMM7o6io0XmDAI2LIc7FiU1xVIm4oKVDyvBQEcAW9Xy8EEqSl5Q2tBeeOvYrexil8fxGBxCUg3cVv9is8hzo4Sd7LJd7S6wdGjHU8Ifqia7-2F2FPRIga-2FpUqMad9RJM106CLDs-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpyB8iAsgD14RdcQ2Fj1EJaTeWjk7Knkf-2FjDsL4HNmEZw-2F0vliXkiMCRdqYO7GXHwoVS-2B0-2FXyDlKkgEicBmR5SX6e2sxK5ZT6kFCqAOFhCiIfGFsKzF8TprxZ-2FD1FbKn6fetkon6MvQAPep02u43a3JLSQeS8ghm5oNRlehKFbgUCk-3D

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.