Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


Hi,

On Tue, Dec 06, 2016 at 11:19:56AM +0100, Stephan Bergmann <sbergman@redhat.com> wrote:
accessMoved - Access of moved variable pReleasedFormat.

<http://dev-builds.libreoffice.org/cppcheck_reports/master/664.html#line-4657>
looks OK, too:  SwDoc::DelTableStyle will either store pReleasedFormat in a
new SwUndo and return an empty std::unique_ptr, or return pReleasedFormat.
That code was added by 
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=0943ee2decb8d5a1a2a5bf3b1c233934a89e9c97>
"GSoC Writer Table Styles; Create by example; fix undo"---any further
thoughts from its author or committer (on cc)?

Hm yes, warning on that unconditionally sounds like a way to generate
lots of false positives. ;-)

As said above, the member function returns nullptr exactly when the
format is already used for undo purposes, I don't see a problem with
that approach.

Regards,

Miklos

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.