New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1396676:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/unoobj/styleuno.cxx: 956 in ScStyleObj::ScStyleObj(ScDocShell *, SfxStyleFamily, 
const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1396676:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/unoobj/styleuno.cxx: 956 in ScStyleObj::ScStyleObj(ScDocShell *, SfxStyleFamily, 
const rtl::OUString &)()
950         aStyleName( rName )
951     {
952         //  pDocShell ist Null, wenn per ServiceProvider erzeugt
953     
954         if (pDocShell)
955             pDocShell->GetDocument().AddUnoObject(*this);
> > >     CID 1396676:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "pStyle_cached" is not initialized in this constructor nor in any 
> > > functions that it calls.
956     }
957     
958     void ScStyleObj::InitDoc( ScDocShell* pNewDocSh, const OUString& rNewName )
959     {
960         if ( pNewDocSh && !pDocShell )
961         {

** CID 1396675:  Null pointer dereferences  (NULL_RETURNS)
/vcl/unx/generic/fontmanager/fontmanager.cxx: 972 in psp::PrintFontManager::getFontFaceNumber(int) 
const()


________________________________________________________________________________________________________
*** CID 1396675:  Null pointer dereferences  (NULL_RETURNS)
/vcl/unx/generic/fontmanager/fontmanager.cxx: 972 in psp::PrintFontManager::getFontFaceNumber(int) 
const()
966     }
967     
968     int PrintFontManager::getFontFaceNumber( fontID nFontID ) const
969     {
970         int nRet = 0;
971         PrintFont* pFont = getFont( nFontID );
> > >     CID 1396675:  Null pointer dereferences  (NULL_RETURNS)
> > >     Dereferencing a null pointer "pFont".
972         nRet = pFont->m_nCollectionEntry;
973         if (nRet < 0)
974             nRet = 0;
975         return nRet;
976     }
977     

** CID 1396674:    (DEADCODE)
/vcl/unx/generic/print/genpspgraphics.cxx: 608 in GenPspGraphics::DrawTextLayout(const 
CommonSalLayout &)()
/vcl/unx/generic/print/genpspgraphics.cxx: 619 in GenPspGraphics::DrawTextLayout(const 
CommonSalLayout &)()


________________________________________________________________________________________________________
*** CID 1396674:    (DEADCODE)
/vcl/unx/generic/print/genpspgraphics.cxx: 608 in GenPspGraphics::DrawTextLayout(const 
CommonSalLayout &)()
602         long nUnitsPerPixel = rLayout.GetUnitsPerPixel();
603         const sal_Unicode* pText = nullptr;
604         int nMinCharPos = 0;
605         int nMaxCharPos = 0;
606         for( int nStart = 0;; )
607         {
> > >     CID 1396674:    (DEADCODE)
> > >     Execution cannot reach the expression "aCharPosAry" inside this statement: "nGlyphCount = 
> > > rLayout->GetN...".
608             int nGlyphCount = rLayout.GetNextGlyphs( nMaxGlyphs, aGlyphAry, aPos, nStart, 
aWidthAry, pText ? aCharPosAry : nullptr );
609             if( !nGlyphCount )
610                 break;
611     
612             DeviceCoordinate nXOffset = 0;
613             for( int i = 0; i < nGlyphCount; ++i )
/vcl/unx/generic/print/genpspgraphics.cxx: 619 in GenPspGraphics::DrawTextLayout(const 
CommonSalLayout &)()
613             for( int i = 0; i < nGlyphCount; ++i )
614             {
615                 nXOffset += aWidthAry[ i ];
616                 aIdxAry[ i ] = nXOffset / nUnitsPerPixel;
617                 sal_GlyphId aGlyphId = aGlyphAry[i] & (GF_IDXMASK | GF_ROTMASK);
618                 if( pText )
> > >     CID 1396674:    (DEADCODE)
> > >     Execution cannot reach the expression "aUnicodes[i]" inside this statement: "aUnicodes[i] = 
> > > ((aCharPosAr...".
619                     aUnicodes[i] = (aCharPosAry[i] >= nMinCharPos && aCharPosAry[i] <= 
nMaxCharPos) ? pText[ aCharPosAry[i] ] : 0;
620                 else
621                     aUnicodes[i] = 0;
622                 aGlyphAry[i] = aGlyphId;
623             }
624     

** CID 1396673:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/shells/annotsh.cxx: 1537 in SwAnnotationShell::ExecUndo(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1396673:  Error handling issues  (CHECKED_RETURN)
/sw/source/uibase/shells/annotsh.cxx: 1537 in SwAnnotationShell::ExecUndo(SfxRequest &)()
1531     
1532                 break;
1533             }
1534     
1535             case SID_REDO:
1536             {
> > >     CID 1396673:  Error handling issues  (CHECKED_RETURN)
> > >     Calling "GetFirstRedoInfo" without checking return value (as is done elsewhere 5 out of 6 
> > > times).
1537                 rSh.GetFirstRedoInfo(nullptr, &nUndoId);
1538                 if (nUndoId == UNDO_CONFLICT)
1539                 {
1540                     rReq.SetReturnValue( SfxUInt32Item(nId, static_cast<sal_uInt32>(nUndoId)) 
);
1541                     break;
1542                 }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy0QDLulCpTFvBZwAW78RtBfWCZfO0eZUlTyQQw9yaqvv7DZZYVeT8MIP-2FmssrxU3bPD9Z2rxK0UIf8L9B-2BUnHX1zj1SYC50HtIict5jlRPhzrk2yU7Dvg8EPw49OBsEhx4HyDbOgT5TFah2geC1zXFzcG4q5FgN4dkqV7p07HgrY-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy0QDLulCpTFvBZwAW78RtBSDLL1-2FVLuu3iUXDyd5TrJio1i3uuiugY6UHgVeI-2FkVLgIUxFBVq8tYX8HME6Fkt79-2BtSQTJBERgJiL8scYujVwEnXPggUg8-2BE8FFqkj5jPVf-2FRP6Kf6QGdsbjB2m-2B2B4OdwRRArBuAhh3XjE0w5vvs-3D