Re: Crash test update

On Wed, Nov 09, 2016 at 03:29:31PM +0200, Khaled Hosny wrote:
> On Wed, Nov 09, 2016 at 11:01:48AM +0000, Caolán McNamara wrote:
> > On Tue, 2016-11-08 at 23:08 +0000, Crashtest VM wrote:
> > > New crashtest update available at http://dev-
> > > builds.libreoffice.org/crashtest/64a708cba9b954afe3331f63c58218eb53b3
> > > d0ce/
> >
> > commit 3a543f1f57aed3beba8879ed46e1f92f657151cb
> > Author: Khaled Hosny <khaledhosny@eglug.org>
> > Date:   Mon Oct 10 00:54:00 2016 +0200
> >
> >     Validate Kashida positions in CommonSalLayout
> >
> > triggers a crash on reexporting fdo58980-3.odt to odt.
> >
> > I've bodged it with...
> >
> > commit 243977708ceaf877e520ef0bb393aa49040d65c9
> > Author: Caolán McNamara <caolanm@redhat.com>
> > Date:   Wed Nov 9 10:58:39 2016 +0000
> >
> >     crashtesting: crash on reexport of fdo58980-3.odt to odt
>
> Where can I find that fdo58980-3.odt file? I think continuing would be
> the same as breaking here, though I’d return true as well since this
> position can’t be ligature if it is across to layout instances.

I guess it is the attachment in [1]. Indeed there is a change in color
right at the Kashida position. I pushed a slightly better fix.

Regards,
Khaled

1. https://bugs.documentfoundation.org/show_bug.cgi?id=58980