Re: concat of OUStringBuffer

Hi,

On Sunday, 2016-10-09 01:42:34 -0700, Laurent BP wrote:

> Something changed recently in master with OUStringBuffer concatenation
>
> aLCIDString does not contain anymore "[$-some string]" but something like
> "[$-[$-[$-0]". Is it a new feature?

I'd rather say it's a bug when assigning the involved OUStringBuffer
(here aLCIDString) to itself again.. so for clarification:

https://gerrit.libreoffice.org/#/c/28666/5 had

    aLCIDString = "[$-" + aLCIDString + "]";
    aFormatStr.insert( nPosInsertLCID, aLCIDString.toString() );

which produced an erroneous "[$-[$-[$-0]"

and https://gerrit.libreoffice.org/#/c/28666/7 has

    aLCIDString.insert( 0, "[$-" );
    aLCIDString.append( "]" );
    rFormatStr.insert( nPosInsertLCID, aLCIDString.toString() );

which produces the expected "[$-107041E]YYYY\-MM\-DD".

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: signature.asc
Description: PGP signature