Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index



Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

53 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 20 of 53 defect(s)


** CID 1373353:  Uninitialized members  (UNINIT_CTOR)
/sc/qa/unit/tiledrendering/tiledrendering.cxx: 392 in <unnamed>::ViewCallback::ViewCallback()()


________________________________________________________________________________________________________
*** CID 1373353:  Uninitialized members  (UNINIT_CTOR)
/sc/qa/unit/tiledrendering/tiledrendering.cxx: 392 in <unnamed>::ViewCallback::ViewCallback()()
386         ViewCallback()
387             : m_bOwnCursorInvalidated(false),
388               m_bViewCursorInvalidated(false),
389               m_bTextViewSelectionInvalidated(false),
390               m_bViewLock(false)
391         {
    CID 1373353:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "m_bGraphicViewSelection" is not initialized in this constructor 
nor in any functions that it calls.
392         }
393     
394         static void callback(int nType, const char* pPayload, void* pData)
395         {
396             static_cast<ViewCallback*>(pData)->callbackImpl(nType, pPayload);
397         }

** CID 1373352:  Uninitialized members  (UNINIT_CTOR)
/filter/source/msfilter/svdfppt.cxx: 4363 in PPTStyleSheet::PPTStyleSheet(const DffRecordHeader &, 
SvStream &, SdrPowerPointImport &, const PPTTextParagraphStyleAtomInterpreter &, const 
PPTTextSpecInfo &)()


________________________________________________________________________________________________________
*** CID 1373352:  Uninitialized members  (UNINIT_CTOR)
/filter/source/msfilter/svdfppt.cxx: 4363 in PPTStyleSheet::PPTStyleSheet(const DffRecordHeader &, 
SvStream &, SdrPowerPointImport &, const PPTTextParagraphStyleAtomInterpreter &, const 
PPTTextSpecInfo &)()
4357                     if ( eNumRuleType == SvxNumRuleType::PRESENTATION_NUMBERING )
4358                         aRule.SetLevel( 0, aNumberFormat );
4359                 }
4360             }
4361             mpNumBulletItem[ i ] = new SvxNumBulletItem( aRule, EE_PARA_NUMBULLET );
4362         }
    CID 1373352:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member field "mpNumBulletItem.detail_values" is not initialized in this 
constructor nor in any functions that it calls.
4363     }
4364     
4365     PPTStyleSheet::~PPTStyleSheet()
4366     {
4367         for ( auto i : o3tl::enumrange<TSS_Type>() )
4368         {

** CID 1373351:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/frmedt/fetab.cxx: 703 in SwFEShell::SetTabRows(const SwTabCols &, bool)()


________________________________________________________________________________________________________
*** CID 1373351:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/frmedt/fetab.cxx: 703 in SwFEShell::SetTabRows(const SwTabCols &, bool)()
697         SET_CURR_SHELL( this );
698         StartAllAction();
699     
700         do
701         {
702             pBox = pBox->GetUpper();
    CID 1373351:  Null pointer dereferences  (FORWARD_NULL)
    Comparing "pBox" to null implies that "pBox" might be null.
703         } while (pBox && !pBox->IsCellFrame());
704     
705         GetDoc()->SetTabRows( rNew, bCurColOnly, static_cast<SwCellFrame*>(pBox) );
706         EndAllActionAndCall();
707     }
708     

** CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()


________________________________________________________________________________________________________
*** CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/unotools/confignode.hxx: 46 in ()
40     
41         class OConfigurationTreeRoot;
42         /** a small wrapper around a configuration node.<p/>
43             Nodes in the terminology used herein are <em>inner</em> nodes of a configuration
44             tree, which means <em>no leafs</em>.
45         */
    CID 1371313:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "utl::OConfigurationNode" may benefit from adding a move assignment operator. See 
other events which show the copy assignment operator being applied to rvalue(s), where a move 
assignment may be faster.
46         class UNOTOOLS_DLLPUBLIC OConfigurationNode : public ::utl::OEventListenerAdapter
47         {
48         private:
49             css::uno::Reference< css::container::XHierarchicalNameAccess >
50                         m_xHierarchyAccess;     /// accessing children grandchildren (mandatory 
interface of our UNO object)
51             css::uno::Reference< css::container::XNameAccess >

** CID 1371312:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/svtools/transfer.hxx: 266 in ()


________________________________________________________________________________________________________
*** CID 1371312:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/svtools/transfer.hxx: 266 in ()
260     
261         virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& rId ) 
throw( css::uno::RuntimeException, std::exception ) override;
262     };
263     
264     struct TransferableDataHelper_Impl;
265     
    CID 1371312:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "TransferableDataHelper" may benefit from adding a move assignment operator. See 
other events which show the copy assignment operator being applied to rvalue(s), where a move 
assignment may be faster.
266     class SVT_DLLPUBLIC TransferableDataHelper
267     {
268         friend class DropTargetHelper;
269     
270     private:
271     

** CID 1371308:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLException.hdl: 16 in ()


________________________________________________________________________________________________________
*** CID 1371308:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLException.hdl: 16 in ()
10     #include "sal/types.h"
11     
12     namespace com { namespace sun { namespace star { namespace uno { class Type; } } } }
13     
14     namespace com { namespace sun { namespace star { namespace sdbc {
15     
    CID 1371308:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "com::sun::star::sdbc::SQLException" may benefit from adding a move assignment 
operator. See other events which show the copy assignment operator being applied to rvalue(s), 
where a move assignment may be faster.
16     class CPPU_GCC_DLLPUBLIC_EXPORT SQLException : public ::css::uno::Exception
17     {
18     public:
19         inline CPPU_GCC_DLLPRIVATE SQLException();
20     
21         inline CPPU_GCC_DLLPRIVATE SQLException(const ::rtl::OUString& Message_, const 
::css::uno::Reference< ::css::uno::XInterface >& Context_, const ::rtl::OUString& SQLState_, const 
::sal_Int32& ErrorCode_, const ::css::uno::Any& NextException_);

** CID 1371305:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/svtools/grfmgr.hxx: 169 in ()


________________________________________________________________________________________________________
*** CID 1371305:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/svtools/grfmgr.hxx: 169 in ()
163                         {
164                             return( mnLumPercent != 0 || mnContPercent != 0 || mnRPercent != 0 
||
165                                     mnGPercent != 0 || mnBPercent != 0 || mfGamma != 1.0 || 
mbInvert );
166                         }
167     };
168     
    CID 1371305:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "GraphicObject" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
169     class SVT_DLLPUBLIC GraphicObject : public SvDataCopyStream
170     {
171         friend class GraphicManager;
172         friend class SdrGrafObj;
173     
174     private:

** CID 1371304:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/uno/dispatcher.hxx: 47 in ()


________________________________________________________________________________________________________
*** CID 1371304:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/uno/dispatcher.hxx: 47 in ()
41         subject to changes.
42     
43         @see uno_Interface
44         @attention
45                   not for public use!
46     */
    CID 1371304:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "com::sun::star::uno::UnoInterfaceReference" may benefit from adding a move 
assignment operator. See other events which show the copy assignment operator being applied to 
rvalue(s), where a move assignment may be faster.
47     class UnoInterfaceReference
48     {
49     public:
50         uno_Interface * m_pUnoI;
51     
52         inline bool is() const

** CID 1371303:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/vcl/inc/impgraph.hxx: 34 in ()


________________________________________________________________________________________________________
*** CID 1371303:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/vcl/inc/impgraph.hxx: 34 in ()
28     
29     class OutputDevice;
30     class GfxLink;
31     struct ImpSwapFile;
32     class GraphicConversionParameters;
33     
    CID 1371303:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "ImpGraphic" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
34     class ImpGraphic
35     {
36         friend class Graphic;
37     
38     private:
39     

** CID 1371302:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/alpha.hxx: 30 in ()


________________________________________________________________________________________________________
*** CID 1371302:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/alpha.hxx: 30 in ()
24     #include <vcl/bitmap.hxx>
25     
26     
27     class ImageList;
28     class BitmapEx;
29     
    CID 1371302:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "AlphaMask" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
30     class VCL_DLLPUBLIC AlphaMask : private Bitmap
31     {
32     public:
33     
34                     AlphaMask();
35                     AlphaMask( const Bitmap& rBitmap );

** CID 1371301:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ndindex.hxx: 35 in ()


________________________________________________________________________________________________________
*** CID 1371301:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/ndindex.hxx: 35 in ()
29     #include <ndarr.hxx>
30     
31     class SwNode;
32     class SwNodes;
33     
34     /// Marks a node in the document model.
    CID 1371301:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "SwNodeIndex" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
35     class SW_DLLPUBLIC SwNodeIndex final : public sw::Ring<SwNodeIndex>
36     {
37         SwNode * m_pNode;
38     
39         // These are not allowed!
40         SwNodeIndex( SwNodes& rNds, sal_uInt16 nIdx ) = delete;

** CID 1371298:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/vcl/inc/unx/saldisp.hxx: 103 in ()


________________________________________________________________________________________________________
*** CID 1371298:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/vcl/inc/unx/saldisp.hxx: 103 in ()
97         inline  int             GetDepth() const { return depth; }
98     
99                 Pixel           GetTCPixel( SalColor nColor ) const;
100                 SalColor        GetTCColor( Pixel nPixel ) const;
101     };
102     
    CID 1371298:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "SalColormap" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
103     class SalColormap
104     {
105         const SalDisplay*       m_pDisplay;
106         Colormap                m_hColormap;
107         std::vector<SalColor>   m_aPalette;         // Pseudocolor
108         SalVisual               m_aVisual;

** CID 1371290:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLWarning.hdl: 13 in ()


________________________________________________________________________________________________________
*** CID 1371290:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/sdbc/SQLWarning.hdl: 13 in ()
7     #include "cppu/macros.hxx"
8     
9     namespace com { namespace sun { namespace star { namespace uno { class Type; } } } }
10     
11     namespace com { namespace sun { namespace star { namespace sdbc {
12     
    CID 1371290:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "com::sun::star::sdbc::SQLWarning" may benefit from adding a move assignment 
operator. See other events which show the copy assignment operator being applied to rvalue(s), 
where a move assignment may be faster.
13     class CPPU_GCC_DLLPUBLIC_EXPORT SQLWarning : public ::css::sdbc::SQLException
14     {
15     public:
16         inline CPPU_GCC_DLLPRIVATE SQLWarning();
17     
18         inline CPPU_GCC_DLLPRIVATE SQLWarning(const ::rtl::OUString& Message_, const 
::css::uno::Reference< ::css::uno::XInterface >& Context_, const ::rtl::OUString& SQLState_, const 
::sal_Int32& ErrorCode_, const ::css::uno::Any& NextException_);

** CID 1371279:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/connectivity/source/drivers/evoab2/NStatement.hxx: 72 in ()


________________________________________________________________________________________________________
*** CID 1371279:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/connectivity/source/drivers/evoab2/NStatement.hxx: 72 in ()
66             {
67                 eFilterAlwaysFalse,
68                 eFilterNone,
69                 eFilterOther
70             };
71     
    CID 1371279:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "connectivity::evoab::QueryData" may benefit from adding a move assignment operator. 
See other events which show the copy assignment operator being applied to rvalue(s), where a 
move assignment may be faster.
72             struct QueryData
73             {
74             private:
75                 EBookQuery*     pQuery;
76     
77             public:

** CID 1371275:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/connectivity/dbmetadata.hxx: 48 in ()


________________________________________________________________________________________________________
*** CID 1371275:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/connectivity/dbmetadata.hxx: 48 in ()
42             around more complex ways to obtain the same information.
43     
44             @todo
45                 Once CWS dba30 is integrated, we could easily add all the meta data
46                 which is part of the "Info" property of a data source.
47         */
    CID 1371275:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "dbtools::DatabaseMetaData" may benefit from adding a move assignment operator. See 
other events which show the copy assignment operator being applied to rvalue(s), where a move 
assignment may be faster.
48         class OOO_DLLPUBLIC_DBTOOLS DatabaseMetaData
49         {
50         private:
51             ::std::unique_ptr< DatabaseMetaData_Impl >    m_pImpl;
52     
53         public:

** CID 1371272:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/rsc/inc/rscdef.hxx: 76 in ()


________________________________________________________________________________________________________
*** CID 1371272:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/rsc/inc/rscdef.hxx: 76 in ()
70                       }
71         bool Evaluate( sal_Int32 * pValue ) const;
72         void AppendMacro( OStringBuffer & ) const;
73     };
74     
75     /*********** R s c I d ***************************************************/
    CID 1371272:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "RscId" may benefit from adding a move assignment operator. See other events which 
show the copy assignment operator being applied to rvalue(s), where a move assignment may be 
faster.
76     class RscId
77     {
78         static      bool bNames;// if false, only count name operation
79     public:
80         RscExpType  aExp;       // number, define or expression
81         sal_Int32   GetNumber() const;

** CID 1371270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/index.hxx: 37 in ()


________________________________________________________________________________________________________
*** CID 1371270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/index.hxx: 37 in ()
31     namespace mark {
32     class IMark;
33     }
34     }
35     
36     /// Marks a character position inside a document model node.
    CID 1371270:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "SwIndex" may benefit from adding a move assignment operator. See other events which 
show the copy assignment operator being applied to rvalue(s), where a move assignment may be 
faster.
37     class SW_DLLPUBLIC SwIndex
38     {
39     private:
40         friend class SwIndexReg;
41     
42         sal_Int32 m_nIndex;

** CID 1371269:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/numrule.hxx: 97 in ()


________________________________________________________________________________________________________
*** CID 1371269:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/numrule.hxx: 97 in ()
91         bool IsEnumeration() const; // #i22362#
92         bool IsItemize() const; // #i29560#
93     };
94     
95     class SwPaM;
96     enum SwNumRuleType { OUTLINE_RULE = 0, NUM_RULE = 1, RULE_END = 2 };
    CID 1371269:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "SwNumRule" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
97     class SW_DLLPUBLIC SwNumRule
98     {
99     
100     public:
101         typedef std::vector< SwTextNode* > tTextNodeList;
102         typedef std::vector< SwTextFormatColl* > tParagraphStyleList;

** CID 1371267:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/connectivity/source/inc/dbase/dindexnode.hxx: 84 in ()


________________________________________________________________________________________________________
*** CID 1371267:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/connectivity/source/inc/dbase/dindexnode.hxx: 84 in ()
78     
79     
80             class ONDXPage;
81     
82             // Index Page Pointer
83             // This is  ref-count pointer class
    CID 1371267:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "connectivity::dbase::ONDXPagePtr" may benefit from adding a move assignment 
operator. See other events which show the copy assignment operator being applied to rvalue(s), 
where a move assignment may be faster.
84             class ONDXPagePtr
85             {
86                 friend  SvStream& WriteONDXPagePtr(SvStream &rStream, const ONDXPagePtr&);
87                 friend  SvStream& operator >> (SvStream &rStream, ONDXPagePtr&);
88     
89                 ONDXPage*   mpPage;

** CID 1371265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/tools/multisel.hxx: 33 in ()


________________________________________________________________________________________________________
*** CID 1371265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/tools/multisel.hxx: 33 in ()
27     #include <set>
28     
29     typedef ::std::vector< Range* > ImpSelList;
30     
31     #define SFX_ENDOFSELECTION      ULONG_MAX
32     
    CID 1371265:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
    Class "MultiSelection" may benefit from adding a move assignment operator. See other events 
which show the copy assignment operator being applied to rvalue(s), where a move assignment may 
be faster.
33     class TOOLS_DLLPUBLIC MultiSelection
34     {
35     private:
36         ImpSelList      aSels;      // array of SV-selections
37         Range           aTotRange;  // total range of indexes
38         sal_uIntPtr     nCurSubSel; // index in aSels of current selected index


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy0xKPbN-2FKCWvQhxX1R2uSAZ7FfqPScZKte4vx8nunIC8xwK3Sf8ySC8kRYgC6cXTE8tuAnztdg6cGMrkuLUk0BypgDmQ1RXqreS1AtmJQ1tBgcU4mc2NGkpHB6ZXd9H3AKSVINKPtYzxp1ZL7Dj11z-2FY4pIhXW1R1hpnAjSG8a-2FE-3D

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy0xKPbN-2FKCWvQhxX1R2uSAZ-2FAVqg1zV2LboATJIi3MOt9SUbBosjXwtwHx9nHcwAmrLJusZwSGeonSGuAwWcSEs3UOz4xBfTS24behdft0TzHwZtWPuauOqtTF25KbmEEKPGqNQf8o3MJ2mtDcpzWRGj6anymjHspn9x0E4UEiLc-3D


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.