Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


In https://bugs.documentfoundation.org/show_bug.cgi?id=97193 its
reported that the insertion of some vals into the InsCellCmd enum in 
f97beeef352fdd9fd4f157a7a4c4f6af8341cbe6 of...

-        INS_INSROWS,
-        INS_INSCOLS,
+        INS_INSROWS_BEFORE,
+        INS_INSROWS_AFTER,
+        INS_INSCOLS_BEFORE,
+        INS_INSCOLS_AFTER,

caused recorded macros to break/change behaviour in 5.1.0 because the
messy macro recorder stuff can only record the number passed around.

It's trivial to change this so that the old ones go back to their old
original values, i.e.

         INS_INSROWS_BEFORE,
-        INS_INSROWS_AFTER,
         INS_INSCOLS_BEFORE,
+        INS_INSROWS_AFTER,
         INS_INSCOLS_AFTER,
         INS_NONE

But of course anything recorded in 5.1 would then break in any version
with this change.

Should we put these vals back to their historical value or accept the
new values as locked in now ?

C.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.