Hi,
I noticed that libreoffice-5-1 is missing a number of Cairo-related commits
that were done in Master but weren't cherry-picked into the 5.1 branch.
Functionally, I can see that SvpSalGraphics::drawAlphaBitmap is missing in
5.1.
This was implemented in:
c1774eb gtk3: implement drawAlphaBitmap for svp/gtk3 backend
and later improved in:
4fee13c gtk3: of course we have a different 1 bit mask format as well
db88445 gtk3: use cairo to do drawAlphaBitmap with scaling
I don't know if this causes any visible defects on the desktop (probably
someone would have notice if it had,) but it certainly breaks in Online
(transparent areas are rendered as black).
There are other candidate gtk3 commits that might be missing from 5.1. For
example:
ac49efd gtk3: track what needs to be implemented
3d22df1 gtk3: implement drawPolyLine for svp/gtk3 backend
872c1b7 gtk3: it's the *Original* device we care about, not the temp clip
hack devices
*Should I submit these patches to libreoffice-5-1 for review?*
Thanks,
-Ash
Context
- Missing Cairo commits from libreoffice-5-1 branch · Ashod Nakashian
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.