Re: New Defects reported by Coverity Scan for LibreOffice

On Sat, 2016-06-11 at 11:17 -0700, scan-admin@coverity.com wrote:
> Hi,
>
> Please find the latest report on new defect(s) introduced to
> LibreOffice found with Coverity Scan.

caolanm->erack: These two look odd to me, can you have a check.

C.

> *** CID 1362685:  Uninitialized variables  (UNINIT)
> /sc/source/core/data/dpobject.cxx: 1888 in
> ScDPObject::ParseFilters(rtl::OUString &,
> std::vector<com::sun::star::sheet::DataPilotFieldFilter,
> std::allocator<com::sun::star::sheet::DataPilotFieldFilter>> &,
> std::vector<com::sun::star::sheet::GeneralFunction,
> std::allocator<com::sun::star::sheet::GeneralFunction>>&, const
> rtl::OUString &)()
> 1882                 {
> 1883                     SvNumberFormatter* pFormatter = mpTableData-
> > GetCacheTable().getCache().GetNumberFormatter();
> 1884                     if (pFormatter)
> 1885                     {
> 1886                         // Parse possible number from
> aQueryValueName and format
> 1887                         // locale independent as aQueryValue.
> > > >     CID 1362685:  Uninitialized variables  (UNINIT)
> > > >     Declaring variable "nNumFormat" without initializer.
> 1888                         sal_uInt32 nNumFormat;
> 1889                         double fValue;
> 1890                         if (pFormatter->IsNumberFormat(
> aQueryValueName, nNumFormat, fValue))
> 1891                             aQueryValue =
> ScDPCache::GetLocaleIndependentFormattedString( fValue, *pFormatter,
> nNumFormat);
> 1892                     }
> 1893                 }
>
> ** CID 1362684:  Uninitialized variables  (UNINIT)
> /sc/source/core/tool/interpr2.cxx: 3363 in
> ScInterpreter::ScGetPivotData()()
>
>
> _____________________________________________________________________
> ___________________________________
> *** CID 1362684:  Uninitialized variables  (UNINIT)
> /sc/source/core/tool/interpr2.cxx: 3363 in
> ScInterpreter::ScGetPivotData()()
> 3357                 else
> 3358                 {
> 3359                     aFilters[i].MatchValueName =
> aSharedString.getString();
> 3360     
> 3361                     // Parse possible number from MatchValueName
> and format
> 3362                     // locale independent as MatchValue.
> > > >     CID 1362684:  Uninitialized variables  (UNINIT)
> > > >     Declaring variable "nNumFormat" without initializer.
> 3363                     sal_uInt32 nNumFormat;
> 3364                     double fValue;
> 3365                     if (pFormatter->IsNumberFormat(
> aFilters[i].MatchValueName, nNumFormat, fValue))
> 3366                         aFilters[i].MatchValue =
> ScDPCache::GetLocaleIndependentFormattedString(
> 3367                                 fValue, *pFormatter,
> nNumFormat);
> 3368                     else