Re: [Libreoffice-commits] core.git: return paths and not URLs

Hey,

On Wed, May 25, 2016 at 4:54 PM, Stephan Bergmann <sbergman@redhat.com>
wrote:

> On 05/24/2016 02:34 AM, Markus Mohrhard wrote:
>
> > commit 8857877aa609de4c8476330c34a24906f5fdc05b
> > Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
> > Date:   Mon May 23 23:47:17 2016 +0200
> >
> >     return paths and not URLs
> >
> >     Change-Id: I03553a1fe98ac7ac780333b2ec247ed0cd781ffb
> >     Reviewed-on: https://gerrit.libreoffice.org/25379
> >     Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
> >     Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
> >
> > diff --git a/desktop/source/app/crashreport.cxx
> > b/desktop/source/app/crashreport.cxx
> > index f1b0828..4f1836d 100644
> > --- a/desktop/source/app/crashreport.cxx
> > +++ b/desktop/source/app/crashreport.cxx
> > @@ -61,7 +61,11 @@ OUString getCrashUserProfileDirectory()
> >      rtl::Bootstrap::expandMacros(url);
> >      osl::Directory::create(url);
> >
> > -    return url;
> > ++#if defined( UNX ) && !defined MACOSX && !defined IOS && !defined
> > ANDROID
> > ++    return url.copy(7);
> > ++#elif defined WNT
> > ++    return url.copy(8);
> > ++#endif
>
> Any reason to not use e.g. osl::FileBase::getSystemPathFromFileURL here?
> A file URL is not a pathname with "file://" prepended.
>
>  }
> >  }
The code was originally part of a code path where I did not want to call
any LibreOffice functions. Now for the last days it was just missing time
to do it properly. I'm currently cleaning the code around the crash report
and that will be part of it.

Regards,
Markus