Re: [Libreoffice-commits] core.git: What is bin/distro-install-file-lists supposed to do?

Any idea, anybody?

On 04/29/2016 05:23 PM, Stephan Bergmann wrote:
> commit ec515932972c6ab116e69844511fccb0bd57aff3
> Author: Stephan Bergmann <sbergman@redhat.com>
> Date:   Fri Apr 29 17:17:34 2016 +0200
>
>     What is bin/distro-install-file-lists supposed to do?
>
>     It is called from the recipe for distro-pack-install in Makefile.in, and I'm
>     (re-/mis-?) using that make target for xdg-app builds (mainly to populate the
>     /usr/share metadata via bin/distro-install-desktop-integration), which then
>     fail because there is no $DESTDIR/gid_Module_Root.
>
>     Is anybody using that make target still in a way where
>     bin/distro-install-file-lists is doing something useful (and why is it that
>     $DESTDIR/gid_Module_Root is existing in that case, but not in mine), or is that
>     some leftover stuff than should be removed?
>
>     Change-Id: I27197c4ae3f57f028f5b181315484e25c1edbaf7
>
> diff --git a/bin/distro-install-file-lists b/bin/distro-install-file-lists
> index 5df56e8..2960f5f 100755
> --- a/bin/distro-install-file-lists
> +++ b/bin/distro-install-file-lists
> @@ -62,7 +62,7 @@ merge_flists()
>  if ! test -f $DESTDIR/gid_Module_Root; then
>      echo "Error: Failed to generate package file lists";
>      echo "       Have you defined DESTDIR?"
> -    exit 1;
> +    exit
>  fi