Re: Fix for Bug 98940

On 04/29/2016 06:52 PM, Matteo Casalin wrote:
> Hi everybody,
>      I submitted to gerrit a one-line fix for bug 98940, a regression introduced by a previous 
> commit of mine.
> I think it's quite safe to push it to master, and I will do that in a few days unless someone 
> reviews/pushes it in the meantime.
>
> The aforementioned bug, however, affects the 5.1 branch and should be evaluated for backporting: 
> what is the best approach to be followed for this?
>
> Thanks in advance and kind regards
> Matteo

As an addition, the bug reporter originally asked for two fixes:

1. allow again -1 as a valid value, that should be fixed by my patch at:
   https://gerrit.libreoffice.org/#/c/24268/

2. allow a maximum "maximum length" positive value higher than 32767. I
   see two issues with this:
   * that value is set by VCLXMultilineEdit::setProperty, that uses a
     sal_Int16:


http://opengrok.libreoffice.org/xref/core/svtools/source/uno/unoiface.cxx#443

     and I have no idea if this can be changed or if it is stable api
   * The control widget can takes values higher than the aforementioned
     32767, and this besides being misleading can also be a source of
     undesired behavior (is the chosen value truncated, saturated or
     what?).

Any comment is much appreciated.

Kind regards
Matteo