Re: A question about table indent

Hi Weike,

If you are interested in contributing to LibreOffice, the best way to get
your patch reviewed is via Gerrit.

https://wiki.documentfoundation.org/Development/gerrit

Regarding your patch, it ignores nLeftBorderDistance completely. You might
need to further investigate why the value is wrong or not suitable for
Writer to conclude that it should be ignored. Otherwise you're making it
correct only for that document.

I also advice that you report an issue and upload the attachment, so it is
can be refered when discussion.
https://bugs.documentfoundation.org








2016-03-15 9:52 GMT+08:00 <weike.liang@cs2c.com.cn>:

> Hi all,
>
>
> Sorry for forgetting to attach the document. Please take a look at the
> position of the last table.
>
>
> Best regards,
>
> Weike Liang
>
>
>
>
>
> ​
>
> -------- 转发邮件信息 --------
>
> 主 题: A question about table indent
> 日 期: Mon, 14 Mar 2016 10:23:29 +0800
> 发件人: <weike.liang@cs2c.com.cn>
> 收件人: libreoffice <libreoffice@lists.freedesktop.org>
>
>
>  Hi all,
>
>
> My colleague from testing department reported a bug about the indent of
> the whole table. I looked into the source code and found the position where
> the problem may be. In
> writerilter/source/dmapper/DomainMapperTableHandler.cxx there exists an
> if-else statement that is responsible to calculate and process the table
> indent. But after i read the annotation i found the lines in if and else
> clauses were wrong. They both should change their positions with each
> other. I don't know if it is right. Please review the changes and give me
> some suggustions. Thanks.
>
>
> Best regards,
>
> Weike Liang
>
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Mark Hung