Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index 


Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

8 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1355507:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdotextpathdecomposition.cxx: 104 in 
<unnamed>::impPathTextPortion::impPathTextPortion(DrawPortionInfo &)()


________________________________________________________________________________________________________
*** CID 1355507:  Uninitialized members  (UNINIT_CTOR)
/svx/source/svdraw/svdotextpathdecomposition.cxx: 104 in 
<unnamed>::impPathTextPortion::impPathTextPortion(DrawPortionInfo &)()
98     
99                     for(sal_Int32 a=0; a < mnTextLength; a++)
100                     {
101                         maDblDXArray.push_back((double)rInfo.mpDXArray[a]);
102                     }
103                 }

    CID 1355507:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "mnParagraph" is not initialized in this constructor nor in any 
functions that it calls.

104             }
105     
106             // for ::std::sort
107             bool operator<(const impPathTextPortion& rComp) const
108             {
109                 if(mnParagraph < rComp.mnParagraph)

** CID 1355505:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/window/toolbox.cxx: 1646 in ToolBox::ToolBox(vcl::Window *, const rtl::OString &, const 
rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &)()


________________________________________________________________________________________________________
*** CID 1355505:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/window/toolbox.cxx: 1646 in ToolBox::ToolBox(vcl::Window *, const rtl::OString &, const 
rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> &)()
1640             mbHorz = true;
1641         else
1642             Resize();
1643     
1644         if (!(GetStyle() & WB_HIDE))
1645             Show();

    CID 1355505:  Uninitialized members  (UNINIT_CTOR)
    Non-static class member "meLayoutMode" is not initialized in this constructor nor in any 
functions that it calls.

1646     }
1647     
1648     ToolBox::~ToolBox()
1649     {
1650         disposeOnce();
1651     }

** CID 1355503:  Null pointer dereferences  (REVERSE_INULL)
/svtools/source/contnr/svimpbox.cxx: 2152 in SvImpLBox::KeyInput(const KeyEvent &)()


________________________________________________________________________________________________________
*** CID 1355503:  Null pointer dereferences  (REVERSE_INULL)
/svtools/source/contnr/svimpbox.cxx: 2152 in SvImpLBox::KeyInput(const KeyEvent &)()
2146                 if ( pNewCursor )
2147                     // new entry selected -> reset current tab position to first tab
2148                     nCurTabPos = FIRST_ENTRY_TAB;
2149                 // if there is no next entry, take the current one
2150                 // this ensures that in case of _one_ entry in the list, this entry is 
selected when pressing
2151                 // the cursor key

    CID 1355503:  Null pointer dereferences  (REVERSE_INULL)
    Null-checking "this->pCursor" suggests that it may be null, but it has already been 
dereferenced on all paths leading to the check.

2152                 if ( !pNewCursor && pCursor )
2153                     pNewCursor = pCursor;
2154     
2155                 if( pNewCursor )
2156                 {
2157                     aSelEng.CursorPosChanging( bShift, bMod1 );

** CID 1355502:  Null pointer dereferences  (REVERSE_INULL)
/svtools/source/contnr/iconviewimpl.cxx: 511 in IconViewImpl::KeyInput(const KeyEvent &)()


________________________________________________________________________________________________________
*** CID 1355502:  Null pointer dereferences  (REVERSE_INULL)
/svtools/source/contnr/iconviewimpl.cxx: 511 in IconViewImpl::KeyInput(const KeyEvent &)()
505                     pNewCursor = pView->PrevVisible(pNewCursor);
506                 } while( pNewCursor && !IsSelectable(pNewCursor) );
507     
508                 // if there is no next entry, take the current one
509                 // this ensures that in case of _one_ entry in the list, this entry is selected 
when pressing
510                 // the cursor key

    CID 1355502:  Null pointer dereferences  (REVERSE_INULL)
    Null-checking "this->pCursor" suggests that it may be null, but it has already been 
dereferenced on all paths leading to the check.

511                 if ( !pNewCursor && pCursor )
512                     pNewCursor = pCursor;
513     
514                 if( pNewCursor )
515                 {
516                     aSelEng.CursorPosChanging( bShift, bMod1 );

** CID 1355501:  Null pointer dereferences  (FORWARD_NULL)
/sfx2/source/control/dispatch.cxx: 1331 in SfxDispatcher::_Update_Impl(bool, bool, bool, 
SfxWorkWindow *)()


________________________________________________________________________________________________________
*** CID 1355501:  Null pointer dereferences  (FORWARD_NULL)
/sfx2/source/control/dispatch.cxx: 1331 in SfxDispatcher::_Update_Impl(bool, bool, bool, 
SfxWorkWindow *)()
1325                 }
1326     
1327                 if ( !bVisible )
1328                     rBar.nResId = 0;
1329             }
1330     

    CID 1355501:  Null pointer dereferences  (FORWARD_NULL)
    Comparing "pIFace" to null implies that "pIFace" might be null.

1331             for ( nNo=0; pIFace && nNo<pIFace->GetChildWindowCount(); nNo++ )
1332             {
1333                 sal_uInt32 nId = pIFace->GetChildWindowId(nNo);
1334                 const SfxSlot *pSlot = pSlotPool->GetSlot( (sal_uInt16) nId );
1335                 SAL_WARN_IF( !pSlot, "sfx.control", "Childwindow slot missing: " << nId );
1336                 if ( bReadOnlyShell )

** CID 1355500:  Compiler dependency  (DELETE_ARRAY)
/vcl/workben/vcldemo.cxx: 646 in DemoRenderer::DrawText::drawStringBox(OutputDevice &, Point, const 
rtl::OUString &, long &)()


________________________________________________________________________________________________________
*** CID 1355500:  Compiler dependency  (DELETE_ARRAY)
/vcl/workben/vcldemo.cxx: 646 in DemoRenderer::DrawText::drawStringBox(OutputDevice &, Point, const 
rtl::OUString &, long &)()
640                         aBottom.Move(pItems[j], aTextRect.GetHeight());
641                         rDev.SetLineColor(COL_RED);
642                         rDev.SetRasterOp(ROP_XOR);
643                         rDev.DrawLine(aTop,aBottom);
644                         rDev.SetRasterOp(ROP_OVERPAINT);
645                     }

    CID 1355500:  Compiler dependency  (DELETE_ARRAY)
    Deleting array variable "pItems" with non-array delete in "delete pItems".

646                     delete pItems;
647     
648                     aPos.Move(aTextRect.GetWidth() + 16, 0);
649                 }
650                 rDev.Pop();
651                 return aPos.X();

** CID 1355499:  Error handling issues  (CHECKED_RETURN)
/sdext/source/pdfimport/test/pdf2xml.cxx: 77 in sal_main_with_args(int, char **)()


________________________________________________________________________________________________________
*** CID 1355499:  Error handling issues  (CHECKED_RETURN)
/sdext/source/pdfimport/test/pdf2xml.cxx: 77 in sal_main_with_args(int, char **)()
71     
72             test::BootstrapFixtureBase aEnv;
73             aEnv.setUp();
74     
75             uno::Reference<pdfi::PDFIRawAdaptor> xAdaptor( new pdfi::PDFIRawAdaptor(OUString(), 
aEnv.getComponentContext()) );
76             xAdaptor->setTreeVisitorFactory(pTreeFactory);

    CID 1355499:  Error handling issues  (CHECKED_RETURN)
    Calling "odfConvert" without checking return value (as is done elsewhere 4 out of 5 times).

77             xAdaptor->odfConvert( aSrcURL, new OutputWrap(aDstURL), nullptr );
78         }
79         catch (const uno::Exception& e)
80         {
81             SAL_WARN("vcl.app", "Fatal exception: " << e.Message);
82             return 1;

** CID 1355498:  Error handling issues  (CHECKED_RETURN)
/basic/source/uno/namecont.cxx: 1956 in basic::SfxLibraryContainer::storeLibraries_Impl(const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool)()


________________________________________________________________________________________________________
*** CID 1355498:  Error handling issues  (CHECKED_RETURN)
/basic/source/uno/namecont.cxx: 1956 in basic::SfxLibraryContainer::storeLibraries_Impl(const 
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool)()
1950                         && !pImplLib->isLoadedStorable()
1951                         && xSourceLibrariesStor.is() /* null for user profile */;
1952                 if (isCopyStorage)
1953                 {
1954                     try
1955                     {

    CID 1355498:  Error handling issues  (CHECKED_RETURN)
    Calling "isStorageElement" without checking return value (as is done elsewhere 22 out of 24 
times).

1956                         xSourceLibrariesStor->isStorageElement(rLib.aName);
1957                     }
1958                     catch (container::NoSuchElementException const&)
1959                     {
1960                         isCopyStorage = false;
1961                     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.