https://bugs.documentfoundation.org/show_bug.cgi?id=86249
--- Comment #3 from Michael Meeks <michael.meeks@collabora.com> ---
I suspect the ambiguity is unpleasant - ie. if there are two constructors with
similar arguments we should have nice, readable, descriptive enum that
distinguishes between the two use-cases; rather than a random number that is
always the same value nAlphaBitCount added to the end =)
It seems we have:
ScopedVclPtrInstance<VirtualDevice> pDevice(&aData, Size(1, 1),
DeviceFormat::DEFAULT);
I wonder if we could overload something into the vdev creation along those
lines; not sure.
Beyond that the bigger problem is that VirtualDevices get created at a 1x1 size
initially - complete with OS resources behind them, which are slow & expensive
to create - and then we re-size them deleting the original stuff =) really the
creation needs to have a smoother flow that passes in the size correctly.
--
You are receiving this mail because:
You are on the CC list for the bug.
Context
- [Bug 86249] clean VirtualDevice constructor ... · bugzilla-daemon
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.