New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
24 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1351882:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1351882:  Incorrect expression  (USELESS_CALL)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 526 in ScPivotLayoutDialog::ApplyChanges()()
520                 ScDPObject *pDPObj = nullptr;
521                 // FIXME: if the new range overlaps with the old one, the table actually 
doesn't move
522                 // and shouldn't therefore be deleted
523                 if ( ( ( rOldRange != aDestinationRange ) && !rOldRange.In( aDestinationRange ) 
)
524                      || bToNewSheet )
525                 {
> > >     CID 1351882:  Incorrect expression  (USELESS_CALL)
> > >     Calling "this->mpDocument->GetDPAtCursor(this->maPivotParameters.nCol, 
> > > this->maPivotParameters.nRow, this->maPivotParameters.nTab)" is only useful for its return 
> > > value, which is ignored.
526                     mpDocument->GetDPAtCursor( maPivotParameters.nCol, maPivotParameters.nRow, 
maPivotParameters.nTab);
527                 }
528                 if (pDPObj)
529                 {
530                     ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
531                     aFunc.RemovePivotTable( *pDPObj, true, false);

** CID 1351881:  Resource leaks  (RESOURCE_LEAK)
/qadevOOo/runner/helper/APIDescGetter.java: 721 in 
helper.APIDescGetter.getFromDirectory(java.lang.String, java.lang.String, boolean)()


________________________________________________________________________________________________________
*** CID 1351881:  Resource leaks  (RESOURCE_LEAK)
/qadevOOo/runner/helper/APIDescGetter.java: 721 in 
helper.APIDescGetter.getFromDirectory(java.lang.String, java.lang.String, boolean)()
715     
716             DescEntry[] subEntries = getSubEntries(csvFile, aEntry);
717     
718             aEntry.SubEntryCount = subEntries != null ? subEntries.length : 0;
719             aEntry.SubEntries = subEntries;
720     
> > >     CID 1351881:  Resource leaks  (RESOURCE_LEAK)
> > >     Variable "csvFile" going out of scope leaks the resource it refers to.
721             return aEntry;
722         }
723     
724         @Override
725         protected ArrayList<String> getSubInterfaces(String job)
726         {

** CID 1351880:  Resource leaks  (RESOURCE_LEAK)
/qadevOOo/runner/helper/APIDescGetter.java: 634 in 
helper.APIDescGetter.getFromClassPath(java.lang.String)()


________________________________________________________________________________________________________
*** CID 1351880:  Resource leaks  (RESOURCE_LEAK)
/qadevOOo/runner/helper/APIDescGetter.java: 634 in 
helper.APIDescGetter.getFromClassPath(java.lang.String)()
628     
629             DescEntry[] subEntries = getSubEntries(csvFile, theEntry);
630     
631             theEntry.SubEntryCount = subEntries != null ? subEntries.length : 0;
632             theEntry.SubEntries = subEntries;
633     
> > >     CID 1351880:  Resource leaks  (RESOURCE_LEAK)
> > >     Variable "csvFile" going out of scope leaks the resource it refers to.
634             return theEntry;
635         }
636     
637         private static DescEntry getFromDirectory(String descPath, String entry,
638                 boolean debug)
639         {

** CID 1351879:  Control flow issues  (MISSING_BREAK)
/libreofficekit/source/gtk/lokdocview.cxx: 880 in globalCallback(void *)()


________________________________________________________________________________________________________
*** CID 1351879:  Control flow issues  (MISSING_BREAK)
/libreofficekit/source/gtk/lokdocview.cxx: 880 in globalCallback(void *)()
874             priv->m_nLoadProgress = 1.0;
875             g_signal_emit (pCallback->m_pDocView, doc_view_signals[LOAD_CHANGED], 0, 1.0);
876         }
877         break;
878         case LOK_CALLBACK_DOCUMENT_PASSWORD_TO_MODIFY:
879             bModify = true;
> > >     CID 1351879:  Control flow issues  (MISSING_BREAK)
> > >     The above case falls through to this one.
880         case LOK_CALLBACK_DOCUMENT_PASSWORD:
881         {
882             char const*const pURL(pCallback->m_aPayload.c_str());
883             g_signal_emit (pCallback->m_pDocView, doc_view_signals[PASSWORD_REQUIRED], 0, pURL, 
bModify);
884         }
885         break;

** CID 1351878:    (DEADCODE)
/sd/source/ui/view/drviewsd.cxx: 180 in sd::DrawViewShell::GetNavigatorWinState(SfxItemSet &)()
/sd/source/ui/view/drviewsd.cxx: 194 in sd::DrawViewShell::GetNavigatorWinState(SfxItemSet &)()


________________________________________________________________________________________________________
*** CID 1351878:    (DEADCODE)
/sd/source/ui/view/drviewsd.cxx: 180 in sd::DrawViewShell::GetNavigatorWinState(SfxItemSet &)()
174         if( nCurrentPage == nFirstPage )
175         {
176             nState |= NAVBTN_FIRST_DISABLED;
177             if( !bEndless )
178                 nState |= NAVBTN_PREV_DISABLED;
179             else
> > >     CID 1351878:    (DEADCODE)
> > >     Execution cannot reach this statement: "nState |= 0x4000U;".
180                 nState |= NAVBTN_PREV_ENABLED;
181         }
182         else
183         {
184             nState |= NAVBTN_FIRST_ENABLED | NAVBTN_PREV_ENABLED;
185         }
/sd/source/ui/view/drviewsd.cxx: 194 in sd::DrawViewShell::GetNavigatorWinState(SfxItemSet &)()
188         if( nCurrentPage == nLastPage )
189         {
190             nState |= NAVBTN_LAST_DISABLED;
191             if( !bEndless )
192                 nState |= NAVBTN_NEXT_DISABLED;
193             else
> > >     CID 1351878:    (DEADCODE)
> > >     Execution cannot reach this statement: "nState |= 0x40000U;".
194                 nState |= NAVBTN_NEXT_ENABLED;
195         }
196         else
197         {
198             nState |= NAVBTN_LAST_ENABLED | NAVBTN_NEXT_ENABLED;
199         }

** CID 1351877:  Possible Control flow issues  (DEADCODE)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 530 in ScPivotLayoutDialog::ApplyChanges()()


________________________________________________________________________________________________________
*** CID 1351877:  Possible Control flow issues  (DEADCODE)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 530 in ScPivotLayoutDialog::ApplyChanges()()
524                      || bToNewSheet )
525                 {
526                     mpDocument->GetDPAtCursor( maPivotParameters.nCol, maPivotParameters.nRow, 
maPivotParameters.nTab);
527                 }
528                 if (pDPObj)
529                 {
> > >     CID 1351877:  Possible Control flow issues  (DEADCODE)
> > >     Execution cannot reach this statement: "aFunc.ScDBDocFunc(this->mpV...".
530                     ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
531                     aFunc.RemovePivotTable( *pDPObj, true, false);
532                     mpViewData->GetView()->CursorPosChanged();
533                 }
534             }
535             return;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939