Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


On 01/19/2016 04:38 PM, Miklos Vajna wrote:
On Tue, Jan 19, 2016 at 06:39:56AM -0800, Oliver Specht <oliver.specht@cib.de> wrote:
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h b/include/LibreOfficeKit/LibreOfficeKit.h
index 7d4210e..8057d75 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -51,6 +51,7 @@ struct _LibreOfficeKitClass
                                               const char* pURL);

      char* (*getError) (LibreOfficeKit* pThis);
+    void  (*freeError)     (const char *pfree);

      LibreOfficeKitDocument* (*documentLoadWithOptions) (LibreOfficeKit* pThis,
                                                          const char* pURL,

Won't this break backwards compatibility with existing clients? I think
you can only append new functions to the end of the function list,
otherwise the LIBREOFFICEKIT_HAS_MEMBER() macro is quite pointless. ;-)

...and the usage of char* vs. char const* seems curiously inconsistent in that API


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.