Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


Hi Lionel,

On Wed, 2016-01-13 at 10:27 +0100, Lionel Elie Mamane wrote:

I'm rather worried about the hunks that remove the
OInterceptor::documentEventOccured stuff, which was registered as a
DocumentEventListener. I'm afraid that this is the mechanism that was
used for embedded databases to do the actual "save embedded database
in the ZIP" step.
Do you aware of any specific scenario where it stopped working because
of this commit?

For firebird, see connectivity/source/drivers/firebird/Connection.cxx
near the end of Connection::construct.
The Connection class is a listener, much like OInterceptor was. There
were no changes in the broadcaster, and I don't understand how removing
one listener could make others stop working. Unless I'm missing
something?

If my above worry is not founded, then what was this
OInterceptor::documentEventOccured used for?
It was used to notify XStatusListeners on whether the component is
modified or not, by sending updates for ".uno:Save" with
enabled/disabled states respectively. See tdf#92203 and the related
bugfix commit.

Maxim

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.