Hi Pasqual, Seems this wasn't answered during the holiday season. On Friday, 2015-12-18 01:26:20 +0100, Pasqual Milvaques wrote:
Yes, I have a question. When I submit a patch for review to gerrit, the people can make comments to it, if I want to submit some changes to the patch I must abandon this patch and submit a new one or can I make changes over the already submitted one?
Basically you submit a patch set of an amended commit with the same Change-Id, which replaces the previous patch set of the same gerrit change, see https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_a_new_version and https://wiki.documentfoundation.org/Development/GitReview#Amending_a_gerrit_change depending on which workflow, ./logerrit (or git push) or git-review, you use. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack
Attachment:
signature.asc
Description: PGP signature