On Thu, 2015-11-26 at 19:03 +0100, Markus Mohrhard wrote:
please add a performance test that ensures that future refactorings
won't regress here. In general any patch claiming performance
improvements should be accompanied by a performance test to make sure
Great idea =) and easy to do too; Kendy ?
Related to the code I wanted to mention that the getenv calls should
be cached in a static variable as they might become expensive when
I was concerned by that too =) I believe the plan is to bin those; but
yes - good to check the perf tests for sure; and to have some nice
before/after step here.
ATB,
Michael.
--
michael.meeks@collabora.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.