Re: [Libreoffice-commits] core.git: Revert "ToolBox: Remove unused methods"

Stephan Bergmann <sbergman -AT- redhat.com>

Thu, 19 Nov 2015 10:17:11 +0100

On 11/18/2015 09:32 PM, Maxim Monastirsky wrote:

commit 78214c982e1fab18b9f6c694a3b56c520da1724d
Author: Maxim Monastirsky <momonasmon@gmail.com>
Date:   Wed Nov 18 22:26:32 2015 +0200

     Revert "ToolBox: Remove unused methods"

     The ImplLoadRes method *is* used in
     ToolBox::ToolBox( vcl::Window* pParent, const ResId& rResId ).
     This change breaks the navigator panel, and therefore the
     JunitTest_toolkit_unoapi_1 test.

     This reverts commit 99648095012187ef284d0a9399a8e12878b2a370.

By the way, a good way to check whether a function is really unused is

to temporarily define it as deleted.

Context

Re: [Libreoffice-commits] core.git: Revert "ToolBox: Remove unused methods" · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.